Skip to content

Conversation

@the-overengineer
Copy link

@the-overengineer the-overengineer commented Feb 3, 2017

  • Fixes handling of input-like components as replacements for basic <input /> elements ('name' was used instead of name).
  • Adds support for using it in minified mode by adding support for spInputLike/data-spInputLike property.
  • Fixes another potential IE issue.
  • Adds documentation about using this.

Supercedes #166

Fixes #164
Fixes #176

@tanzim
Copy link

tanzim commented Feb 6, 2017

Any ETA for this?

@skeet
Copy link
Contributor

skeet commented Feb 21, 2017

Is there an ETA for this? The library won't work in IE11 until this is merged I believe.

@rkrueger11
Copy link

Any way to get this merged soon?

@robertjd
Copy link
Member

robertjd commented Mar 16, 2017

Thanks @Tweety-FER ! I have confirmed that this fixes the issue and appears to be non-breaking, so I will merge and release.

@robertjd robertjd merged commit 9bcd900 into master Mar 16, 2017
@robertjd robertjd deleted the fix/input-like-form-handling branch March 16, 2017 17:45
@robertjd
Copy link
Member

Hello @tanzim @skeet @rkrueger11 this is now available in 2.0.1, please let me know if it works? I can also release as a patch to the 1.x series if needed.

Also, if you haven't heard the news, please note that Stormpath is Joining Forces With Okta. As such we won't be adding any new features to this library, we're going to be focusing on migrating existing functionality to Okta. Our primary focus is on patching our server integrations, such as express-stormpath to work with Okta (we'll also be providing a tool to migrate your data to Okta). Please see the Migration FAQ for more information about features are coming over. If you have any questions please reach out to support@stormpath.com so that we can help, thanks!

@rkrueger11
Copy link

@robertjd Yep, that works for me. Thanks!

Just needs to be pushed to NPM now. :)

Congrats on joining Okta!

@robertjd
Copy link
Member

@rkrueger11 Thanks! And published to npm :)

@tanzim
Copy link

tanzim commented Mar 21, 2017

@robertjd Thanks for this.

Would it be possible to back-port the changes to 1.x?
We're using cookie based auth and would like to stick to it because of the additional security advantages http only cookies provide. Sadly our API is on a different domain which means we're subject to automatic switch to client API in 2x (till #175 is resolved).

Good luck with the acquisition and looking forward to the integration with Okta for the SDKs.

robertjd pushed a commit that referenced this pull request Apr 25, 2017
Attempting to package the fixes in PR #177

This is based on 1.3.4 and has not yet integrated the changes in 1.3.5
robertjd pushed a commit that referenced this pull request Apr 25, 2017
Attempting to package the fixes in PR #177 and 1.3.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants