feat(stories): Add published_at_gt and other date related query parameters
#65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frastel
commented
Jul 24, 2025
silasjoisten
requested changes
Jul 24, 2025
OskarStark
reviewed
Jul 24, 2025
OskarStark
reviewed
Jul 24, 2025
OskarStark
reviewed
Jul 24, 2025
OskarStark
reviewed
Jul 24, 2025
src/Domain/Value/QueryParameter/FirstPublishedAtQueryParameter.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jul 24, 2025
silasjoisten
requested changes
Jul 25, 2025
src/Domain/Value/QueryParameter/FirstPublishedAtQueryParameter.php
Outdated
Show resolved
Hide resolved
silasjoisten
requested changes
Jul 26, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
============================================
+ Coverage 93.88% 93.91% +0.02%
- Complexity 461 488 +27
============================================
Files 72 79 +7
Lines 1620 1675 +55
============================================
+ Hits 1521 1573 +52
- Misses 99 102 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OskarStark
changed the title
published_at_gt and other date related query parameters (#64)published_at_gt and other date related query parameters
Contributor
Author
|
Any further feedback? |
OskarStark
approved these changes
Aug 1, 2025
Contributor
Author
|
Anything I could do so that the PR could be merged? |
Collaborator
|
Hey @frastel sorry for the long response time. i will take a look here |
tests/Unit/Domain/Value/QueryParameter/FirstPublishedAtLtTest.php
Outdated
Show resolved
Hide resolved
tests/Unit/Domain/Value/QueryParameter/FirstPublishedAtGtTest.php
Outdated
Show resolved
Hide resolved
Collaborator
|
Thank you very much @frastel |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for these query parameters:
published_at_gtpublished_at_ltfirst_published_at_gtfirst_published_at_ltupdated_at_gtupdated_at_ltMore about this topic in the issue: #64