feat: add the mint_and_register_ip_and_make_derivative method #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonnie57
requested review from
AndyBoWu,
edisonz0718,
limengformal,
lucas2brh and
sebsadface
as code owners
lucas2brh
approved these changes
Aug 15, 2025
|
|
||
|
|
||
| class TestSPGNFTOperations: | ||
| @pytest.fixture(scope="module") |
There was a problem hiding this comment.
I assume we remove these since they are included in the newly added test.
There was a problem hiding this comment.
I move into conftest.py, which saves the common fixture.
| ip_asset, | ||
| "_parse_tx_ip_registered_event", | ||
| return_value={"ip_id": IP_ID, "token_id": 1}, | ||
| return_value={"ip_id": IP_ID, "token_id": 3}, |
There was a problem hiding this comment.
Why do we use a different hardcoded token_id? I mean I don't know the reason that use 3 instead of 1.
There was a problem hiding this comment.
Just to make sure all test cases pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mint_and_register_ip_and_make_derivativemethodRegistrationResponseconfest.pyTest Plan