Skip to content

Conversation

@aandrewchung
Copy link
Contributor

Description

This PR standardizes naming conventions across the Story Protocol Python SDK by:

  1. Converting method names from camelCase to snake_case for better Python style compliance
  2. Updating variable names for consistency
  3. Centralizing constants in utils/constants.py and updating imports
  4. Removing unnecessary whitespace and improving code formatting

These changes improve code readability, maintainability, and adherence to Python style guidelines (PEP 8).

Test Plan

    1. Run all existing tests to ensure functionality is preserved despite naming changes
    1. Verify that all renamed methods are properly referenced throughout the codebase
    1. Check that constant imports are working correctly
    1. Ensure all client classes still function as expected

Related Issue

n/a

Notes

  • This is a breaking change for anyone using the SDK with the old method names
  • Documentation should be updated to reflect the new naming conventions

Copy link
Contributor

@bpolania bpolania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aandrewchung aandrewchung merged commit fb27daf into main Apr 10, 2025
10 checks passed
@aandrewchung aandrewchung deleted the andrew/code-improvement branch April 10, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants