Skip to content

fix(telemetry): make strands agent invoke_agent span as INTERNAL spanKind #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2025
Merged

fix(telemetry): make strands agent invoke_agent span as INTERNAL spanKind #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c123f09
fix(telemetry): make strands agent invoke_agent span as INTERNAL span…
poshinchen Oct 20, 2025
96bf1b5
fix(telemetry): make strands agent invoke_agent and chat span as INTE…
poshinchen Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/strands/telemetry/tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ def start_model_invoke_span(
# Add additional kwargs as attributes
attributes.update({k: v for k, v in kwargs.items() if isinstance(v, (str, int, float, bool))})

span = self._start_span("chat", parent_span, attributes=attributes, span_kind=trace_api.SpanKind.CLIENT)
span = self._start_span("chat", parent_span, attributes=attributes, span_kind=trace_api.SpanKind.INTERNAL)
self._add_event_messages(span, messages)

return span
Expand Down Expand Up @@ -588,7 +588,7 @@ def start_agent_span(
attributes.update({k: v for k, v in kwargs.items() if isinstance(v, (str, int, float, bool))})

span = self._start_span(
f"invoke_agent {agent_name}", attributes=attributes, span_kind=trace_api.SpanKind.CLIENT
f"invoke_agent {agent_name}", attributes=attributes, span_kind=trace_api.SpanKind.INTERNAL
)
self._add_event_messages(span, messages)

Expand Down
5 changes: 3 additions & 2 deletions tests/strands/telemetry/test_tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def test_start_model_invoke_span(mock_tracer):

mock_tracer.start_span.assert_called_once()
assert mock_tracer.start_span.call_args[1]["name"] == "chat"
assert mock_tracer.start_span.call_args[1]["kind"] == SpanKind.CLIENT
assert mock_tracer.start_span.call_args[1]["kind"] == SpanKind.INTERNAL
mock_span.set_attribute.assert_any_call("gen_ai.system", "strands-agents")
mock_span.set_attribute.assert_any_call("gen_ai.operation.name", "chat")
mock_span.set_attribute.assert_any_call("gen_ai.request.model", model_id)
Expand Down Expand Up @@ -188,7 +188,7 @@ def test_start_model_invoke_span_latest_conventions(mock_tracer):

mock_tracer.start_span.assert_called_once()
assert mock_tracer.start_span.call_args[1]["name"] == "chat"
assert mock_tracer.start_span.call_args[1]["kind"] == SpanKind.CLIENT
assert mock_tracer.start_span.call_args[1]["kind"] == SpanKind.INTERNAL
mock_span.set_attribute.assert_any_call("gen_ai.provider.name", "strands-agents")
mock_span.set_attribute.assert_any_call("gen_ai.operation.name", "chat")
mock_span.set_attribute.assert_any_call("gen_ai.request.model", model_id)
Expand Down Expand Up @@ -670,6 +670,7 @@ def test_start_agent_span(mock_tracer):

mock_tracer.start_span.assert_called_once()
assert mock_tracer.start_span.call_args[1]["name"] == "invoke_agent WeatherAgent"
assert mock_tracer.start_span.call_args[1]["kind"] == SpanKind.INTERNAL
mock_span.set_attribute.assert_any_call("gen_ai.system", "strands-agents")
mock_span.set_attribute.assert_any_call("gen_ai.agent.name", "WeatherAgent")
mock_span.set_attribute.assert_any_call("gen_ai.request.model", model_id)
Expand Down