[bug]: update color of links in Menu for consistency

[Adzouz]

What version of design-system are you using?

Strapi Design System: 2.0.0-rc.26
All browsers

What's Wrong?

Whenever we use a link in a Menu component (as a Menu.Item with the isLink property), the color changes for primary500 (the default color of links in the CMS) which makes sense but not in the case of a Menu list where items need to be consistent.

To Reproduce

Go to Storybook > Components > SimpleMenu > with links

Expected Behaviour

I talked with @lucasboilly and he agreed on this rule for all items of a Menu (no matter if it's a link or a button):

• Default state
  • Text: neutral800
  • Icon: neutral500
• Disabled state
  • Text: neutral500
  • Icon: neutral300

The only variant that should exist is the "danger" variant (for now, in the future, depending on the needs, we could implement new variants).

Before:

After:

🚀

[HoldenFolk]

@Adzouz this issue appears to be solved. Should this branch be closed?

[Adzouz]

Hey @HoldenFolk the issue is not fixed on design system side (see https://design-system.strapi.io/?path=/story/design-system-components-simplemenu--with-links). We still need to address the issue directly there.
Don't hesitate if you have any question 😊

[HichamELBSI]

No worries, I'll open a PR about it.