Skip to content

Conversation

@gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Feb 17, 2022

Before this PR images in the media library were stretched, if they don't fit the proportions of CardAsset. That's something we should avoid and instead always show the real proportions of the image.

Before After
Screen Shot 2022-02-17 at 13 09 45 Screen Shot 2022-02-17 at 13 09 37

Refs: https://strapi-inc.atlassian.net/browse/CONTENT-89

@vercel
Copy link

vercel bot commented Feb 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

design-system – ./

🔍 Inspect: https://vercel.com/strapijs/design-system/7xBfBqYggtGfZaAwtNSWoZcY9cqz
✅ Preview: https://design-system-git-content-89-ml-stretch-strapijs.vercel.app

design-system-website – ./website

🔍 Inspect: https://vercel.com/strapijs/design-system-website/HTv2uwz1hkgD3C3uzmJ7PZUxmTQD
✅ Preview: https://design-system-website-git-content-89-ml-stretch-strapijs.vercel.app

Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@HichamELBSI HichamELBSI changed the base branch from main to 1.0.0 February 21, 2022 09:11
@HichamELBSI HichamELBSI added the pr: fix This PR is fixing a bug label Feb 21, 2022
Copy link
Collaborator

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HichamELBSI HichamELBSI merged commit 488730f into 1.0.0 Feb 21, 2022
@HichamELBSI HichamELBSI deleted the CONTENT-89/ml-stretch branch February 21, 2022 09:22
@HichamELBSI HichamELBSI added this to the 1.0.0 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix This PR is fixing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants