Skip to content

Fix/wording fixes #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HichamELBSI merged 7 commits into from
Apr 11, 2022
Merged

Fix/wording fixes #587

HichamELBSI merged 7 commits into from
Apr 11, 2022

Conversation

@philippkhon
Copy link
Contributor

@philippkhon philippkhon commented Mar 21, 2022

Removed the empty lines under some images (which cased blank spaces) & did a wording update for Principles page.

Refs:

@vercel
Copy link

vercel bot commented Mar 21, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

design-system – ./

🔍 Inspect: https://vercel.com/strapijs/design-system/9sdCxLFcwmRJEfN9dfsKWGVxmQKW
✅ Preview: https://design-system-git-fix-wording-fixes-strapijs.vercel.app

design-system-website – ./website

🔍 Inspect: https://vercel.com/strapijs/design-system-website/Dahdnw2u8uN45vpYMgfDPS6CGz46
✅ Preview: https://design-system-website-git-fix-wording-fixes-strapijs.vercel.app

maevalienard
maevalienard approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@maevalienard maevalienard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

HichamELBSI
HichamELBSI reviewed Mar 23, 2022
View reviewed changes
website/data/pages/principles.mdx Outdated
# What is Strapi Design System ?

It's an open-source design system for plugins, products and digital experiences. This design system consists of design principles and guidelines, created from our design vision, components, design tools and resources, and a vibrant community of contributors.
It's an open-source Design System for plugins, products, and digital experiences. This design system consists of design principles and guidelines, created from our design vision, components, design tools and resources, and a vibrant community of contributors. Strapi Design System is the new version of Buffet.js.
Copy link
Collaborator

@HichamELBSI HichamELBSI Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strapi Design System is the new version of Buffet.js.

Are we sure about this sentence? @soupette Wdyt about that?

Copy link
Collaborator

@HichamELBSI HichamELBSI Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the Design System isn't related to BuffetJS at all. Should we really quote BuffetJS?

Copy link
Contributor Author

@philippkhon philippkhon Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maevalienard could you pls have a look

Copy link
Contributor

@soupette soupette Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree @HichamELBSI we should not mention Buffet.js

Copy link
Contributor

@maevalienard maevalienard Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a discussion regarding this point in a Slack thread here: https://strapihq.slack.com/archives/CEN0F9WF6/p1644587440299209

Copy link
Contributor

@maevalienard maevalienard Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would work to me :D

Copy link
Collaborator

@HichamELBSI HichamELBSI Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you ok with this modification @philippkhon ?

Copy link
Contributor Author

@philippkhon philippkhon Apr 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks @HichamELBSI

Copy link
Collaborator

@HichamELBSI HichamELBSI Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philippkhon Any update regarding this PR?

Copy link
Contributor Author

@philippkhon philippkhon Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HichamELBSI I've just updated the last line accordingly

@HichamELBSI HichamELBSI added the pr: doc This PR contributes to the documentation in this repository (READMEs or Comments) label Mar 23, 2022
@HichamELBSI HichamELBSI added this to the 1.1.0 milestone Mar 23, 2022
@HichamELBSI HichamELBSI self-assigned this Apr 1, 2022
HichamELBSI
HichamELBSI approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @philippkhon

@HichamELBSI HichamELBSI merged commit c275e2b into main Apr 11, 2022
@HichamELBSI HichamELBSI deleted the fix/wording-fixes branch April 11, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HichamELBSI HichamELBSI HichamELBSI approved these changes

+2 more reviewers

@soupette soupette soupette left review comments

@maevalienard maevalienard maevalienard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@HichamELBSI HichamELBSI

Labels

pr: doc This PR contributes to the documentation in this repository (READMEs or Comments)

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@philippkhon @HichamELBSI @soupette @maevalienard