Skip to content

Conversation

@alexandrebodin
Copy link
Member

What does it do?

Add node 18 support info in the doc

Why is it needed?

We added support for node 18 in the codebase and will be released with the upcoming 4.3.9

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@alexandrebodin alexandrebodin added target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch). pr: chore labels Sep 8, 2022
@vercel
Copy link

vercel bot commented Sep 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
documentation ✅ Ready (Inspect) Visit Preview Sep 8, 2022 at 2:46PM (UTC)

Copy link
Contributor

@stb13579 stb13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the supported Node version is also mentioned in the AWS deployment guide. I can submit a separate PR if you would like.

@stb13579 stb13579 added this to the 4.3.9 milestone Sep 9, 2022
@stb13579 stb13579 added source: Dev Docs PRs/issues targeting the Developer Docs size: small If the PR includes only 1 file with <10 lines of text or a small code fix labels Sep 9, 2022
@alexandrebodin
Copy link
Member Author

I noticed the supported Node version is also mentioned in the AWS deployment guide. I can submit a separate PR if you would like.

Looking at the Guide it also shows how to install node 14 so we would need to explain you can install any of the versions I suppose. I think this would be better put in another PR if you don't mind :)

@stb13579
Copy link
Contributor

stb13579 commented Sep 9, 2022

I noticed the supported Node version is also mentioned in the AWS deployment guide. I can submit a separate PR if you would like.

Looking at the Guide it also shows how to install node 14 so we would need to explain you can install any of the versions I suppose. I think this would be better put in another PR if you don't mind :)

OK for me. We are going to revise the guide in Q4 anyway. Thanks for the PR!

@stb13579 stb13579 merged commit 3df4f36 into main Sep 9, 2022
@stb13579 stb13579 deleted the chore/node-18 branch September 9, 2022 09:42
@pwizla
Copy link
Collaborator

pwizla commented Sep 20, 2022

Thanks, @alexandrebodin.
I guess this means this part should be updated as well (screenshot 👇), or do we still recommend 14.x for now?
Screenshot 2022-09-20 at 10 45 13

@alexandrebodin
Copy link
Member Author

Node 18 isn't LTS yet so we don't recommend it for now but will once it goes LTS and 14 goes in maintenance :D

@pwizla
Copy link
Collaborator

pwizla commented Sep 20, 2022

Node 18 isn't LTS yet so we don't recommend it for now but will once it goes LTS and 14 goes in maintenance :D

OK, thanks, but should we recommend 16 now (instead of 14) in the last sentence ("The 14.x 16.x version is most recommended by Strapi")?

@alexandrebodin
Copy link
Member Author

Ha sorry yes node 16 should totally be recommended :D

@tadwohlrapp
Copy link

Node 18 isn't LTS yet so we don't recommend it for now but will once it goes LTS and 14 goes in maintenance :D

Node.js 18.12.0 reached LTS status a couple days ago, so will it become the recommended version now?

@pwizla
Copy link
Collaborator

pwizla commented Nov 2, 2022

Node.js 18.12.0 reached LTS status a couple days ago, so will it become the recommended version now?

I'll check with the engineering team :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: chore size: small If the PR includes only 1 file with <10 lines of text or a small code fix source: Dev Docs PRs/issues targeting the Developer Docs target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants