Dark Mode: new custom theme extension syntax #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganelacheny
added
source: Dev Docs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pwizla
approved these changes
Oct 3, 2022
ronronscelestes
approved these changes
Oct 6, 2022
gu-stav
reviewed
Oct 7, 2022
Comment on lines
+510
to
+513
| To extend the theme, use either: | ||
| - the `config.theme.light` key for the Light mode | ||
| - the `config.theme.dark` key for the Dark mode |
There was a problem hiding this comment.
I'd omit that and add a comment in the above code example instead.
There was a problem hiding this comment.
I don't think a comment in the code example should replace this explanation, especially since otherwise there's no proper information about how to extend the theme in the "Theme extension" section. I'll leave this here. But I integrated all you other suggestions, thank you for your review!
| ::: note | ||
| Strapi applications can be displayed either in Light or Dark mode (see [administrator profile setup in the User Guide](/user-docs/latest/getting-started/introduction.md#setting-up-your-administrator-profile)), however custom theme extension is only applied for Light mode. When choosing Dark mode for a Strapi application, theme customizations are ignored. | ||
| ::: caution | ||
| The former syntax `config.theme` to extend the theme will soon be deprecated by Strapi, and will stop being supported when the next major release is available. We encourage you to update any custom theme using the new syntax that supports custom development for both Light and Dark modes. |
There was a problem hiding this comment.
Suggested change
| The former syntax `config.theme` to extend the theme will soon be deprecated by Strapi, and will stop being supported when the next major release is available. We encourage you to update any custom theme using the new syntax that supports custom development for both Light and Dark modes. | |
| The former syntax for `config.theme` without `light` or `dark` keys is deprecated at will be removed in the next major release. We encourage you to update your custom theme to use the new syntax that supports light and dark modes. |
Co-authored-by: Gustav Hansen <gu@stav.dev>
Co-authored-by: Gustav Hansen <gu@stav.dev>
Co-authored-by: Gustav Hansen <gu@stav.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of Admin customization documentation:
config.themeis being replaced withconfig.theme.lightandconfig.theme.dark👉 See contribution PR