-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add custom Markdown Containers for callouts #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note: Using babel-style for plugins declarations as it seems to work better with multiple declarations for vuepress-plugin-container
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/strapijs/documentation/6ZoCogBC9MwicWUEc3eLFh9FhRrA |
docs/.vuepress/config.js
Outdated
defaultTitle: '🤓 ' | ||
}], | ||
['vuepress-plugin-container', { | ||
type: 'prerequisites', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if we should generalize the name 🤔 instead of using prerequisites
since we use it elsewhere besides just prerequisites.
Though if plan to add a bunch (would be nice) we probably need to document them somewhere, not needed for now but just a thought
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point, thank you!
I've updated the PR to:
- keep this one (so we have the "PREREQUISITES" defaultTitle ready)
- and create a generic 'callout', with the same look but without the defaultTitle
This way, if we ever decide to change the CSS of prerequisites, it wouldn't impact other callouts :-)
Btw I've already started documenting them in Notion 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the PR description to include these changes :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you for the documentation. Might be good at some point to allow the public to view this but we can tackle that later.
Indeed, that's planned, the contributing guide is going to be updated this quarter 🙂 |
In our mind, they are 3 different levels: - important, the less strong - caution, medium importance ( = VuePress's default 'warning') - warning, the strongest ( = VuePress's default 'danger')
We decided that we'll go with a unique callout, "caution". The title can still be adjusted when necessary.
Closing in favor of #368 |
What does it do?
This PR:
:::prerequisites
,:::strapi
and a:::generic
callout (see screenshots below for end result)