Skip to content

Conversation

pwizla
Copy link
Collaborator

@pwizla pwizla commented Jul 1, 2021

What does it do?

This PR:

  • adds vuepress-plugin-container
  • adds 3 custom Markdown containers: :::prerequisites, :::strapi and a :::generic callout (see screenshots below for end result)
  • customize the tip callout to always include a lightbulb
  • uses them in files where we previously hacked the CSS of built-in containers

Screenshot 2021-07-01 at 16 54 00
Screenshot 2021-07-01 at 16 48 20
Screenshot 2021-07-02 at 10 43 43

@vercel
Copy link

vercel bot commented Jul 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/strapijs/documentation/6ZoCogBC9MwicWUEc3eLFh9FhRrA
✅ Preview: https://documentation-git-repo-custom-containers-strapijs.vercel.app

@pwizla pwizla self-assigned this Jul 1, 2021
@pwizla pwizla requested review from derrickmehaffy and lauriejim and removed request for derrickmehaffy July 1, 2021 15:15
@pwizla pwizla added source: repo PRs/issues not targeting a specific documentation but rather affecting the whole repo internal PRs created by the Strapi core team labels Jul 1, 2021
@pwizla pwizla requested a review from derrickmehaffy July 1, 2021 15:15
defaultTitle: '🤓 '
}],
['vuepress-plugin-container', {
type: 'prerequisites',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we should generalize the name 🤔 instead of using prerequisites since we use it elsewhere besides just prerequisites.

Though if plan to add a bunch (would be nice) we probably need to document them somewhere, not needed for now but just a thought

Copy link
Collaborator Author

@pwizla pwizla Jul 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point, thank you!

I've updated the PR to:

  • keep this one (so we have the "PREREQUISITES" defaultTitle ready)
  • and create a generic 'callout', with the same look but without the defaultTitle

This way, if we ever decide to change the CSS of prerequisites, it wouldn't impact other callouts :-)

Btw I've already started documenting them in Notion 🙂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR description to include these changes :-)

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for the documentation. Might be good at some point to allow the public to view this but we can tackle that later.

@pwizla pwizla requested a review from meganelacheny July 7, 2021 07:29
@pwizla
Copy link
Collaborator Author

pwizla commented Jul 7, 2021

LGTM, Thank you for the documentation. Might be good at some point to allow the public to view this but we can tackle that later.

Indeed, that's planned, the contributing guide is going to be updated this quarter 🙂

@pwizla pwizla changed the title Add Custom Markdown Containers Add custom Markdown Containers for callouts Jul 8, 2021
In our mind, they are 3 different levels:
- important, the less strong
- caution, medium importance ( = VuePress's default 'warning')
- warning, the strongest ( = VuePress's default 'danger')
We decided that we'll go with a unique callout, "caution". The title
can still be adjusted when necessary.
@pwizla
Copy link
Collaborator Author

pwizla commented Jul 20, 2021

Closing in favor of #368

@pwizla pwizla closed this Jul 20, 2021
@pwizla pwizla deleted the repo/custom-containers branch July 22, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal PRs created by the Strapi core team source: repo PRs/issues not targeting a specific documentation but rather affecting the whole repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants