-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update node env var to fix build bug #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/strapijs/documentation/J4b79DuoCCwsmZe1uakLHrwRLCaW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add temp workaround for legacy domain (#307) * Add temp workaround for legacy domain Adds a function that checks for node_env and if it's legacy it sets the base key to `/documentation/` else it just sets the base to the vuepress default `/` Also added a replacement for the landing meta-refresh * revert resource center redirection * add resource center link * Update node env var to fix build bug (#381) * Add a local node script for legacy (#382) * Removed Slack from the Navbar Community dropdown (#384) * Edit the "Create a Go File" section (#388) The word "built-in" is much more common than "inbuilt". Go has packages, and we don't need to refer to them as "packages/modules". Also, add a missing comma. * remove DO managed db warning (#390) Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Add hiring link (#387) Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Case for 1 can be handled in loop (#370) Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Change code snippet for service create customisation (#372) * Change code snippet for service create customisation * Review changes * VuePress enhancements (#368) * Add consistency * Add strapi & prerequisites Markdown containers Note: Using babel-style for plugins declarations as it seems to work better with multiple declarations for vuepress-plugin-container * Use :::strapi and :::prerequisites in existing docs * Add generic callout, tweak strapi & tip callouts, and clean config file * Clean up unused inline styles from Markdown files * Remove 🤓 from Markdown files in strapi callouts as it's now included * Use generic callout for congratulations in QSG * Add api-call, request and response custom containers * Fully redesign style for request & response containers * Use api-callout container on existing documentation * Remove emoji from :::strapi as it's included * Add 'note' custom callout * Add 'important', 'caution' and 'warning' custom callouts In our mind, they are 3 different levels: - important, the less strong - caution, medium importance ( = VuePress's default 'warning') - warning, the strongest ( = VuePress's default 'danger') * Remove important callout & cleanup CSS We decided that we'll go with a unique callout, "caution". The title can still be adjusted when necessary. * Merge branch 'repo/snippets' into repo/vuepress-enhanced * Apply new callouts and minimal tab styles everywhere * Apply minimal tabs to integration guides * Update VuePress to 1.8.2 * Temporarily setting root url (testing Vercel deploy) * Revert "Temporarily setting root url (testing Vercel deploy)" This reverts commit ba7b7d2. * Use code-blocks and code-groups everywhere appropriate * Tweak request/response CSS based on designers feedback * Simplify some wordings in i18n doc * Apply api-call/request/response containers throughout the docs * Tweak request/response CSS for use outside of :::api-call * Update callouts in the user guide * Remove Google Analytics Vuepress plugin and add GTM See [this PR](#380) * Temp remove yarn.lock to fix conflicts * Fix emoji for warning callout * Converting warning to note callout in Templates file * Fix QSG callouts * Add yarn.lock * Remove marketing note at end of 21yunbox hosting guide * Removing GTM script from plugins (it's already in head) * Don't make text prop required in badges as a default is already provided Co-authored-by: Mégane Lacheny <megane.lacheny@strapi.io> * Highlight active tab in blue instead of default VuePress green (#393) * Fix CLI commands for Hand-on path in QSG (#395) * Launch the server: added steps to execute build & start on windows (#394) Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Remove breaking markdown on laravel page (#398) * Remove breaking markdown on laravel page There was a line that broke the layout of the entire page, making everything after the tag be placed inline. By removing this it will all be normal and readable again. * Close a block in the angular documentation * Close a block in the gridsome documentation * Close a block in the 11ty documentation * Update python.md (#400) Fixed the syntax error in line 125. * Update laravel.md (#402) Fixed a wrong word * small grammar fix (#405) from "is uses" to "uses" * Update is/are conjugation mistake in FAQ (#406) * Add Okta example to SSO (#396) Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Grammar correction (#414) * Use a nodejs version supported by Strapi (#411) Node v10 is not supported anymore. See https://strapi.io/documentation/developer-docs/latest/setup-deployment-guides/deployment.html Use Node v14 in Standard Environment. See https://cloud.google.com/appengine/docs/standard/nodejs/runtime#node.js-14 Note about Flexible Environment: It will derive the right Node version from package.json. See https://cloud.google.com/appengine/docs/flexible/nodejs/runtime Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Fix socketPath usage on google app engine (#392) See https://stackoverflow.com/a/67395883/856702 Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Update laravel.md (#410) A config file is needed Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Fix for the Okta sample config (#419) * Fix grammar (#421) * Update migration-guide-3.4.x-to-3.4.4.md * Update migration-guide-3.4.x-to-3.4.4.md * Update sentence for initializer in folder structure (#426) * Update README.md (#427) Update Node version: https://strapi.io/documentation/developer-docs/latest/setup-deployment-guides/installation/cli.html#preparing-the-installation `Node.js (opens new window): only LTS versions are supported (version 12.x minimum). Other versions of Node.js may not be compatible with the latest release of Strapi. The 14.x version is most recommended by Strapi.` * [dev/latest-guides-auth-request] Fixed grammatical error (#431) * Fixed grammatical error * Fixed to better match style guide Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * npm build command doesn't work. Use npm run build (#440) See: https://stackoverflow.com/questions/29939697/npm-build-doesnt-run-the-script-named-build-in-package-json This should also be updated across the docs wherever its found. Maybe I'll go hunting soon if this one gets merged (first time contributor here 😊) * Update note in v3 migration guides (#449) * fix publicationState filter docs (#425) Co-authored-by: DMehaffy <derrickmehaffy@gmail.com> Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Believe there is a typo in the file name (#471) servers.js should be server.js * [v3] CLI Node version reference (#470) * [v3] CLI Node version reference * make it clear we won't backport node 16 support Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Add Strapi handbook links (#492) * Update 'Database Access' location (#487) The mongodb dashboard does not have an 'Overview' section anymore as implied in the strapi mongodb docs. They now have a 'Deployment' section and 'Database Access' has been moved to the 'Security' section. Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> * Update amazon-aws.md (#484) Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> Co-authored-by: Richard Nsama <kasonde.nsama@gmail.com> Co-authored-by: Mike Casebolt <mikebolt@gmail.com> Co-authored-by: Collisio Technologies <54179909+Collisio@users.noreply.github.com> Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com> Co-authored-by: Pierre Burgy <pierre.burgy@gmail.com> Co-authored-by: Daniel Gustaw <gustaw.daniel@gmail.com> Co-authored-by: Bartek Kowalik <bkowalik@users.noreply.github.com> Co-authored-by: Mégane Lacheny <megane.lacheny@strapi.io> Co-authored-by: ericrinaldo <52439561+ericrinaldo@users.noreply.github.com> Co-authored-by: Marinus van Velzen <rienvanvelzen@gmail.com> Co-authored-by: Asiful Alam <47291401+Faheem2k19@users.noreply.github.com> Co-authored-by: Precious Luke <lukeprecious20@yahoo.com> Co-authored-by: Mustapha Hamoui <mustapha.hamoui@gmail.com> Co-authored-by: Victor Jansson <victor.jansson@gmail.com> Co-authored-by: Chidume Nnamdi <kurtwanger40@gmail.com> Co-authored-by: Tobias L. Maier <me@tobiasmaier.info> Co-authored-by: Cihad Turhan <cihadturhan@users.noreply.github.com> Co-authored-by: Josh Post <4186365+posty72@users.noreply.github.com> Co-authored-by: Sujay <33504917+SujayPrabhu96@users.noreply.github.com> Co-authored-by: teinett <teine@teine.ru> Co-authored-by: Brendan Laney <Brlaney@outlook.com> Co-authored-by: Chizaram Nwazuo <44569600+nwazuo@users.noreply.github.com> Co-authored-by: petr-hajek <38785076+petr-hajek@users.noreply.github.com> Co-authored-by: Craig Harman <324026+craigharman@users.noreply.github.com> Co-authored-by: Aboluwade Oluwasegun <36123150+aboluwade-oluwasegun@users.noreply.github.com> Co-authored-by: KAILASA's Sri Nithya Priyeshananda <68758690+sripriyesha@users.noreply.github.com>
Fixes bug with legacy deployment