Skip to content

Conversation

@koyanyaroo
Copy link

What does it do?

If I understand correctly The code example of an email service documentation is misleading

so I assume createCoreService('api::email.email') instead of createCoreService('api::restaurant.restaurant')

according to // path: ./src/api/email/services/email.js
and strapi.service('api::apiName.serviceName');

and

createCoreController('api::user.user') instead of createCoreController('api::restaurant.restaurant')

according to // path: ./src/api/user/controllers/user.js
and strapi.controller('api::api-name.controller-name');

Why is it needed?

If my understanding is correct, then it's maybe need to be changed

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@strapi-cla
Copy link

strapi-cla commented Feb 13, 2022

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Feb 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/strapijs/documentation/415xGiPFQMeFCgijPPn4H7pN9PBv
✅ Preview: https://documentation-git-fork-koyanyaroo-fix-email-ser-454e5f-strapijs.vercel.app

@pwizla pwizla self-assigned this Feb 14, 2022
@pwizla pwizla added size: small If the PR includes only 1 file with <10 lines of text or a small code fix target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch). issue: discussion internal PRs created by the Strapi core team source: Dev Docs PRs/issues targeting the Developer Docs and removed internal PRs created by the Strapi core team labels Feb 14, 2022
@derrickmehaffy
Copy link
Member

duplicate of #727

@pwizla
Copy link
Collaborator

pwizla commented Feb 17, 2022

Thank you for your contribution @koyanyaroo !
FYI this pull request is a duplicate of #727. You might want to follow further progress on this topic on the other PR.

We will probably keep api::restaurant.restaurant here. We think this part of the documentation might be misunderstood and we are working with back-end developers to improve these examples, so our readers get a better understanding. This PR will probably stay closed but I will get back to you once we improve this part of the documentation 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue: discussion size: small If the PR includes only 1 file with <10 lines of text or a small code fix source: Dev Docs PRs/issues targeting the Developer Docs target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants