-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Callout for unsupported v4 Docker image #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/strapijs/documentation/93epXVfeVXCHNfPaTxQQGBJzZxqi |
|
Hello! This PR is for consistency with the readme file update by @alexandrebodin . |
|
A callout is not enough. The current documentation does not lead to a successful installation of strapi v3 with docker. The relevant docs, which include further steps necessary, are at The status quo of this page leads to a very unsatisfying experience. That's not at all stapi stands for. |
Hi @rowild. Thanks for your feedback. We are trying to not add any additional v3 documentation to the v4 docs. Do I understand your request correctly, that you want us to update the v3 Docker documentation? |
|
@StrapiShaun I know that you do not support anything with v3 anymore, and that is understandable (even though I would say that, as long as there is no strapi v4 docker available, v3 should still get attention). However, IMO existing documentation should at least lead to a working setup. Therefore I would like to suggest to add a link to the strapi docker github repo, where there is definitely more information available should it be needed. This could easily be done by simply adding a new paragraph after the "If you need further information, please refer to the strapi-docker readme." IMO, that should be there anyway, also, when a v4 edition should be released. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Shaun, thanks for taking care of this :-)
Just a minor question about the link "style", in the comments.
docs/developer-docs/latest/setup-deployment-guides/installation/docker.md
Outdated
Show resolved
Hide resolved
|
If I see that correctly you intend to keep an installation guide for a v3 feature in the v4 documentation? Why, if so? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hello @rowild, We think it is necessary to have the callout now to reduce confusion. We are still exploring options for how to treat Docker in the documentation and waiting for additional feedback from our Product and Engineering teams. |
|
@StrapiShaun Yes, I know, the callout was my idea after all. However, it is simply inconsistent to have a v3 workflow in a v4 docu. Really, I do not know, why strapi decides to do so? I work with many CMSs and it is common to link to an old instruction if necessary, but not to provide one in a wrong context. This case is absolutely such a situation: link to v3 as long as there is nothing for v4. THAT would remove confusion once and for all. Not only a callout. Or what am I missing? |
|
@rowild. We are aware that the Docker documentation is imperfect. We have decided to make this minimally viable change in the short term while we discuss how to handle it going forward. |
|
@StrapiShaun No offense, but what is sooooooo difficult to delete superfluous text? If it wasn't a copy from v3, it wouldn't be there anyway, since nobody would have written it...??? |
@rowild I believe this discussion is not moving in a productive way, I wish to remind you of our Community Code of Conduct, specifically the following sections: As part of our responsibilities I am giving you an official warning as a Strapi employee that your conduct is not falling within what we believe to be correct behavior. You may disagree with our decisions, and we respect that, but we have made these decisions with the information we have. If you have concerns that you wish to address in private I am happy to schedule a call with you one on one, just email community@strapi.io and I will schedule something. |
9233dfb to
bb43b7c
Compare
What does it do?
Added callout to clarify that Strapi is not currently providing a Docker image for v4 and a link to a Community solution.
Why is it needed?
Describe the issue you are solving.
Related issue(s)/PR(s)
#826