Skip to content

Conversation

@gpene
Copy link
Contributor

@gpene gpene commented Jun 21, 2022

What does it do?

Add page re: Using/Configuring/Developing Providers

Why is it needed?

Allows the removal (and stops duplicating) providers related content from individual Plugin pages

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@vercel
Copy link

vercel bot commented Jun 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
documentation ✅ Ready (Inspect) Visit Preview Jul 11, 2022 at 7:51AM (UTC)

@pwizla pwizla added source: Dev Docs PRs/issues targeting the Developer Docs internal PRs created by the Strapi core team target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch). labels Jun 22, 2022
Copy link
Collaborator

@meganelacheny meganelacheny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice documentation @gpene 👏
Structure and content/explanations are clear. I added a few comments and suggestions mostly about writing style and text formatting (make sure to check our style guide if you have a doubt).

canonicalUrl: https://docs.strapi.io/developer-docs/latest/development/using-providers.html
---

# Using Providers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Developer Documentation, H1 titles usually don't follow this format. It looks a bit weird to have that one title starting with a verb.


# Using Providers

Certain [plugins](../../../user-docs/latest/plugins/introduction-to-plugins.md) can be extended via the installation and configuration of additional [providers](../../../user-docs/latest/plugins/introduction-to-plugins.md#providers).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For providers I think I would add a call-to-action kind of link, instead of just adding the link like you did, so that readers are more clearly invited to go and check the user guide 🤔 Usually we use the following formatting for that: (see Providers documentation in the User Guide) (or something like that).
What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really a fan of that style/formatting - I don't think it adds much in the way of an "invitation" to go read further than a simple inline link, and in sections with many links adds needless clutter and word count.
If we're set on that style I can change it no problem, but I don't see the value IMO?

Copy link
Collaborator

@pwizla pwizla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Gabriel, great PR!
I have a couple of changes to suggest, but most of them were already pointed out by Mégane, so I've just added a 👍 emoji to her comments.

I have 2 more suggestions:

  • We could probably use more cross-reference links, for instance:

    • when you mention plugins configuration, link to the Setup & Deployment > Configurations > Optional > Plugins section,
    • when you mention environment variables, link to the corresponding documentation, etc.
      I might be missing a few more (I already mentioned security middleware in a comment).
  • Since it seems like providers use some configuration options defined in ./config/plugins.js, I think that in the plugins configurations file, I'd mention providers.
    Apparently, different providers have different configuration options, so we probably can't have a table like we did with plugins. But at least I'd mention something in a callout, something like:

    ::: note
    The `./config/plugins.js` file can also include configuration options for providers (see [providers documentation](link to the configuration header in the providers' doc file)
    :::
    

What do you think?

@pwizla
Copy link
Collaborator

pwizla commented Jul 13, 2022

As discussed with you, closed in favor of #992, thank you, guys!

@pwizla pwizla closed this Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal PRs created by the Strapi core team source: Dev Docs PRs/issues targeting the Developer Docs target: v4 Documentation PRs/issues targeting content from docs.strapi.io (main branch).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants