-
Couldn't load subscription status.
- Fork 1.2k
Update Upload Plugin docs #983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| </div> | ||
|
|
||
| ## Upload files | ||
| ## Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would review that whole "Examples" section to be honest. I don't think the content is just examples, all those configuration options for files imported via the Media Library should be integrated/explained properly in the Upload plugin documentation. Happy to discuss that with you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same. Happy to join the discussion if you need me 🤗
| canonicalUrl: https://docs.strapi.io/developer-docs/latest/plugins/upload.html | ||
| --- | ||
|
|
||
| # Upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open question: should we mention in the TOC something like "Upload (Media Library)"? Just to make sure that when users scroll down the TOC to look for a Media Library documentation, they know that this is the right file? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this isn't Media Library documentation - where that is a component of the admin panel it is properly documented in the User Guide, which is where users would/should look for such content. If they are in the Developer docs, the naming should reflect what exists in code, hence upload plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Gabriel for the work. I've added some minor comments and questions. And I also think the Examples section needs to be revised. Happy to discuss it if needed :)
| </div> | ||
|
|
||
| ## Upload files | ||
| ## Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same. Happy to join the discussion if you need me 🤗
| canonicalUrl: https://docs.strapi.io/developer-docs/latest/plugins/upload.html | ||
| --- | ||
|
|
||
| # Upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea to me :)
|
As discussed with you, closed in favor of #992, thank you, guys! |
What does it do?
Restructures the existing content + inline with other plugin docs given new template / providers docs being added.
Why is it needed?
Related issue(s)/PR(s)
#926 (comment)
Still needed