-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content-releases): add content releases #18586
Conversation
* chore(content-releases): check license and feature flag * chore(content-releases): update snapshots * chore(content-releases): fix features import * chore(content-releases): Make content-releases package public to publish it * chore(content-releases): add missing clean cmd on strapi package * chore(content-releases): fix problem with DS version
@joshuaellis @remidej @simotae14 @Marc-Roig I don't know what do you think, but I think we are safe to merge this into main and publish this package with all the others and with all its changes, because we have the feature flag so this plugin won't be installed at least you set that feature flag. Or should we hold this PR until the alpha? wdyt? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the idea of a stealth release behind a flag. As long as it's disabled by default and not documented until the alpha, I think that's great.
Haven't tested yet
faf2227
to
dcd6867
Compare
dcd6867
to
0f4e7e3
Compare
can you produce an experimental build we can ensure it's not being pulled in? :) |
…age and the detail page (#18589) * add routes and sidebar link * change pluginId implementation * remove comments * add admin permissions * change the bootstrap type in Plugin as conditional * remove permissions for the moment to find a better solution in another ticket
… and controllers (#18613) * chore(content-releases): create new content type and add create and find many services and controllers * chore(content-releases): sanitize output and add pagination * update snapshots * chore(content-releases): move find logic to service * chore(content-releases): create release action model uid constant * chore(content-releases): find to findMany --------- Co-authored-by: Simone Taeggi <startae14@gmail.com>
…tion (#18650) * create the releases header and the create releases modal * fix review comments * remove chunk name * remove useless empty lines * fix lint error * fix review comments * fix review comments * reduce number of tests * fix review comments * change test description and refactor the ui structure * small fixes
Size Change: 0 B Total Size: 645 kB ℹ️ View Unchanged
|
89a3810
to
7c580f7
Compare
7c580f7
to
9bb870f
Compare
…8918) * chore(content-releases): add entries to content releases actions * chore(content-releases): add entries relation to findMany content-release's actions * chore(content-releases): improve findOne with actions code * chore(Content-releases): remi feedback * chore(content-releases): fix getReleaseActions response type * chore(content-releases): change findOne and findActions endpoints * chore(content-releases): fix error in release's tests * chore(content-releases): use queryBuilder from strapi.db * chore(content-releases): use queryBuilder from strapi.db
* first draft implementation edit release * add dialog unit test * add permission to the edit button * add permissions type and remove old unit test * add createAction to the PermissionMap * fix type errors * fix unit test * fix lint error * fix review comments * change state naming * change dialog to modal
* feat(content-releases): publish a release * feat(content-releases): publish is enabled if you have releases publish permissions * chore(content-releases): Mark's feedback * Update packages/core/content-releases/server/src/services/release.ts Co-authored-by: markkaylor <mark.kaylor@strapi.io> --------- Co-authored-by: markkaylor <mark.kaylor@strapi.io>
Co-authored-by: Alexandre BODIN <alexandrebodin@users.noreply.github.com> Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Experimental available with future flags + content-releases 🍾
|
* feat(content-releases): delete a release endpoint * feat(content-releases): delete actions when deleting a release * feat(content-releases): apply mark's feedback * feat(content-releases): use transaction for delete a release
* first implementation details page * refactor code based on comments received * move the countDays function inside the ReleaseDetails page * fix unit tests for the Details page * add padding bottom heading * fix type errors * integrate new fields to the Details page * fix types * change the way we handle the timepassed since release creation * fix unit test * fix review comments * unit test control table content * fix review comments * remove mocking useParams * refactor provideTags and invalidateTags * improves in rtk tags and createdBy type * fix last review comments * increase warning timeout to solve issues with unit tests * add AnErrorOccured content if we have errors * fix type error * fix condition * remove new line --------- Co-authored-by: Fernando Chavez <fernando.chavez@strapi.io>
* feat(content-releases): add action column to details view * apply marks feedback * apply marks feedback
…19055) * feat(content-releases): add functionality to publish release button * apply mark's feedback * apply simone's feedback
* implement the delete action * fix missing prop * fix type errors * add translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it do?
Introduces the new content releases plugin into main, so we avoid any possible conflicts. The plugin won't be installed if you don't have a right license and the feature flag set on your local environment.
How to test it?
cms-content-releases
feature enabled.STRAPI_FEATURES_FUTURE_CONTENT_RELEASES
to true in your appconfig/features.js
file in your strapi app with the following config: