Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content-releases): add content releases #18586

Merged
merged 38 commits into from
Dec 15, 2023
Merged

Conversation

Feranchz
Copy link
Contributor

@Feranchz Feranchz commented Oct 26, 2023

What does it do?

Introduces the new content releases plugin into main, so we avoid any possible conflicts. The plugin won't be installed if you don't have a right license and the feature flag set on your local environment.

How to test it?

  1. You need to have an enterprise license with the cms-content-releases feature enabled.
  2. You need to set the .env variable STRAPI_FEATURES_FUTURE_CONTENT_RELEASES to true in your app
  3. You need a config/features.js file in your strapi app with the following config:
module.exports = ({ env }) => ({
  future: {
    contentReleases: env.bool('STRAPI_FEATURES_FUTURE_CONTENT_RELEASES', false),
  },
});

markkaylor and others added 2 commits October 26, 2023 11:49
* chore(content-releases): check license and feature flag

* chore(content-releases): update snapshots

* chore(content-releases): fix features import

* chore(content-releases): Make content-releases package public to publish it

* chore(content-releases): add missing clean cmd on strapi package

* chore(content-releases): fix problem with DS version
@Feranchz Feranchz self-assigned this Oct 26, 2023
@Feranchz Feranchz added the pr: feature This PR adds a new feature label Oct 26, 2023
@Feranchz
Copy link
Contributor Author

@joshuaellis @remidej @simotae14 @Marc-Roig I don't know what do you think, but I think we are safe to merge this into main and publish this package with all the others and with all its changes, because we have the feature flag so this plugin won't be installed at least you set that feature flag.

Or should we hold this PR until the alpha?

wdyt? 🤔

Copy link
Contributor

@remidej remidej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the idea of a stealth release behind a flag. As long as it's disabled by default and not documented until the alpha, I think that's great.

Haven't tested yet

packages/core/admin/scripts/build.js Outdated Show resolved Hide resolved
@joshuaellis
Copy link
Member

can you produce an experimental build we can ensure it's not being pulled in? :)

simotae14 and others added 5 commits October 31, 2023 10:50
…age and the detail page (#18589)

* add routes and sidebar link

* change pluginId implementation

* remove comments

* add admin permissions

* change the bootstrap type in Plugin as conditional

* remove permissions for the moment to find a better solution in another ticket
… and controllers (#18613)

* chore(content-releases): create new content type and add create and find many services and controllers

* chore(content-releases): sanitize output and add pagination

* update snapshots

* chore(content-releases): move find logic to service

* chore(content-releases): create release action model uid constant

* chore(content-releases): find to findMany

---------

Co-authored-by: Simone Taeggi <startae14@gmail.com>
…tion (#18650)

* create the releases header and the create releases modal

* fix review comments

* remove chunk name

* remove useless empty lines

* fix lint error

* fix review comments

* fix review comments

* reduce number of tests

* fix review comments

* change test description and refactor the ui structure

* small fixes
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Size Change: 0 B

Total Size: 645 kB

ℹ️ View Unchanged
Filename Size
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB
examples/getstarted/build/index.html 610 B
examples/getstarted/build/main.********.js 638 kB
examples/getstarted/build/runtime~main.********.js 4.25 kB

compressed-size-action

@markkaylor markkaylor changed the title feat(content-releases): Content releases plugin first configuration feat(content-releases): content releases plugin first configuration Nov 13, 2023
@markkaylor markkaylor changed the title feat(content-releases): content releases plugin first configuration feat(content-releases): add content releases Dec 1, 2023
Feranchz and others added 9 commits December 4, 2023 10:10
…8918)

* chore(content-releases): add entries to content releases actions

* chore(content-releases): add entries relation to findMany content-release's actions

* chore(content-releases): improve findOne with actions code

* chore(Content-releases): remi feedback

* chore(content-releases): fix getReleaseActions response type

* chore(content-releases): change findOne and findActions endpoints

* chore(content-releases): fix error in release's tests

* chore(content-releases): use queryBuilder from strapi.db

* chore(content-releases): use queryBuilder from strapi.db
* first draft implementation edit release

* add dialog unit test

* add permission to the edit button

* add permissions type and remove old unit test

* add createAction to the PermissionMap

* fix type errors

* fix unit test

* fix lint error

* fix review comments

* change state naming

* change dialog to modal
* feat(content-releases): publish a release

* feat(content-releases): publish is enabled if you have releases publish permissions

* chore(content-releases): Mark's feedback

* Update packages/core/content-releases/server/src/services/release.ts

Co-authored-by: markkaylor <mark.kaylor@strapi.io>

---------

Co-authored-by: markkaylor <mark.kaylor@strapi.io>
Co-authored-by: Alexandre BODIN <alexandrebodin@users.noreply.github.com>
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
@markkaylor
Copy link
Contributor

markkaylor commented Dec 8, 2023

Experimental available with future flags + content-releases 🍾

npx create-strapi-app@0.0.0-experimental.24e6b11e8e7573960aa757a0d1b4eadb39d60fa6 test-releases --quickstart

Feranchz and others added 9 commits December 11, 2023 19:03
* feat(content-releases): delete a release endpoint

* feat(content-releases): delete actions when deleting a release

* feat(content-releases): apply mark's feedback

* feat(content-releases): use transaction for delete a release
* first implementation details page

* refactor code based on comments received

* move the countDays function inside the ReleaseDetails page

* fix unit tests for the Details page

* add padding bottom heading

* fix type errors

* integrate new fields to the Details page

* fix types

* change the way we handle the timepassed since release creation

* fix unit test

* fix review comments

* unit test control table content

* fix review comments

* remove mocking useParams

* refactor provideTags and invalidateTags

* improves in rtk tags and createdBy type

* fix last review comments

* increase warning timeout to solve issues with unit tests

* add AnErrorOccured content if we have errors

* fix type error

* fix condition

* remove new line

---------

Co-authored-by: Fernando Chavez <fernando.chavez@strapi.io>
* feat(content-releases): add action column to details view

* apply marks feedback

* apply marks feedback
…19055)

* feat(content-releases): add functionality to publish release button

* apply mark's feedback

* apply simone's feedback
* implement the delete action

* fix missing prop

* fix type errors

* add translation
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work all of you, it's awesome to see the first EE plugin, with new feature flags, written in TS first & using redux-toolkit query.

Ryan Gosling Clap GIF

^^ even Ryan is pleased, and i've got it on good authority he's hard to please.

@Feranchz Feranchz merged commit c469b9f into main Dec 15, 2023
146 of 148 checks passed
@Feranchz Feranchz deleted the feature/content-releases branch December 15, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants