Stabilize the Protocol and implement add't Stores #16

strawgate · 2025-09-25T02:44:29Z

Significant refactor, project rename, test suite introduction, more store support.

Initial Scaffolding for sync implementation

Closes

Copilot

Pull Request Overview

This PR performs general code clean-up across the codebase, focusing on parameter naming consistency and documentation improvements. The changes aim to make the API more intuitive and self-documenting.

Renamed constructor parameters to be more descriptive and consistent across store implementations
Updated test models to include additional fields for better test coverage
Improved documentation strings with clearer parameter descriptions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
tests/adapters/test_pydantic.py	Added URL field to Product model and updated sample data
src/kv_store_adapter/stores/elasticsearch/store.py	Renamed `client` parameter to `elasticsearch_client` and added configuration defaults
src/kv_store_adapter/stores/disk/store.py	Renamed `cache` and `path` parameters to `disk_cache` and `directory` with enhanced documentation
README.md	Updated description from "async-first" to "async-only" for clarity

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

key-value/key-value-aio/src/key_value/aio/stores/disk/store.py

src/kv_store_adapter/stores/disk/store.py

Copilot

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tests/adapters/test_pydantic.py

Copilot

Pull Request Overview

Copilot reviewed 62 out of 64 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

key-value/key-value-shared/src/key_value/shared/utils/compound.py

Copilot

Pull Request Overview

Copilot reviewed 62 out of 64 changed files in this pull request and generated 8 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tests/test_types.py

tests/stores/disk/test_disk.py

key-value/key-value-aio/tests/stores/conftest.py

src/kv_store_adapter/stores/utils/compound.py

src/kv_store_adapter/stores/memcached/store.py

src/kv_store_adapter/stores/elasticsearch/store.py

key-value/key-value-aio/src/key_value/aio/stores/disk/multi_store.py

Copilot

Pull Request Overview

Copilot reviewed 63 out of 65 changed files in this pull request and generated 11 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tests/stores/wrappers/test_single_collection.py

tests/stores/wrappers/test_prefix_collection.py

tests/stores/wrappers/test_passthrough_cache.py

key-value/key-value-aio/tests/stores/wrappers/test_clamp_ttl.py

key-value/key-value-aio/tests/stores/conftest.py

src/kv_store_adapter/wrappers/passthrough_cache.py

key-value/key-value-shared/src/key_value/shared/utils/compound.py

Copilot

Pull Request Overview

Copilot reviewed 63 out of 65 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/kv_store_adapter/stores/utils/compound.py

src/kv_store_adapter/stores/utils/time_to_live.py

key-value/key-value-shared/src/key_value/shared/utils/managed_entry.py

Copilot

Pull Request Overview

Copilot reviewed 99 out of 120 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 99 out of 120 changed files in this pull request and generated 9 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

key-value/key-value-shared/src/key_value/shared/utils/compound.py

key-value/key-value-aio/src/key_value/aio/stores/valkey/store.py

key-value/key-value-aio/src/key_value/aio/stores/redis/store.py

key-value/key-value-aio/src/key_value/aio/stores/mongodb/store.py

key-value/key-value-aio/src/key_value/aio/stores/memcached/store.py

key-value/key-value-aio/src/key_value/aio/stores/memory/store.py

key-value/key-value-aio/src/key_value/aio/stores/elasticsearch/store.py

key-value/key-value-aio/src/key_value/aio/stores/disk/store.py

key-value/key-value-aio/src/key_value/aio/stores/disk/multi_store.py

Copilot

Pull Request Overview

Copilot reviewed 99 out of 120 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

key-value/key-value-shared/src/key_value/shared/utils/managed_entry.py

key-value/key-value-aio/src/key_value/aio/stores/elasticsearch/store.py

Copilot

Pull Request Overview

Copilot reviewed 230 out of 248 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

scripts/build_sync_library.py

pyproject.toml

Copilot

Pull Request Overview

Copilot reviewed 227 out of 250 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 227 out of 250 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

key-value/key-value-sync/src/key_value/sync/code_gen/stores/disk/multi_store.py

key-value/key-value-sync/src/key_value/sync/code_gen/stores/elasticsearch/store.py

Copilot

Pull Request Overview

Copilot reviewed 232 out of 254 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

strawgate added 3 commits September 24, 2025 21:43

Readme cleanup

9e05441

Add pydantic anyurl test case

8324451

docstring updates

9d4c9a5

Copilot AI review requested due to automatic review settings September 25, 2025 02:44

strawgate had a problem deploying to pypi September 25, 2025 02:44 — with GitHub Actions Failure

Copilot AI reviewed Sep 25, 2025

View reviewed changes

key-value/key-value-aio/src/key_value/aio/stores/disk/store.py Show resolved Hide resolved

key-value/key-value-aio/src/key_value/aio/stores/disk/store.py Show resolved Hide resolved

src/kv_store_adapter/stores/disk/store.py Outdated Show resolved Hide resolved

Additional clean-up

bc4e627

strawgate had a problem deploying to pypi September 25, 2025 13:01 — with GitHub Actions Failure

Fix disk init tests

afafecb

Copilot AI review requested due to automatic review settings September 25, 2025 13:03

strawgate temporarily deployed to pypi September 25, 2025 13:03 — with GitHub Actions Inactive

Copilot AI reviewed Sep 25, 2025

View reviewed changes

tests/adapters/test_pydantic.py Outdated Show resolved Hide resolved

strawgate added 2 commits September 25, 2025 08:14

Additional clean-up

d77e936

Refactor project

da814d5

Copilot AI review requested due to automatic review settings September 26, 2025 04:55

Copilot AI reviewed Sep 26, 2025

View reviewed changes

key-value/key-value-shared/src/key_value/shared/utils/compound.py Show resolved Hide resolved

key-value/key-value-shared/src/key_value/shared/utils/compound.py Show resolved Hide resolved

strawgate added 2 commits September 26, 2025 07:42

Quote python versions

c71485b

skip docker tests on platforms without docker

59200d9

Copilot AI review requested due to automatic review settings September 26, 2025 12:46

Copilot AI reviewed Sep 26, 2025

View reviewed changes

strawgate added 2 commits September 26, 2025 07:50

Add timeout, lint check

56add19

Remove python 3.14 add pre-step for python 3.13 test

f00fe1a

Copilot AI review requested due to automatic review settings September 26, 2025 12:53

Copilot AI reviewed Sep 26, 2025

View reviewed changes

strawgate added 2 commits September 26, 2025 08:12

PR Feedback

89cb2ee

Close Disk Cache on deletion

0add7f3

Copilot AI review requested due to automatic review settings September 26, 2025 14:05

Copilot AI reviewed Sep 26, 2025

View reviewed changes

strawgate added 2 commits September 26, 2025 12:57

Updates to keystores, add valkey and memcache

830116e

Readme update and lint check

729bdd4

strawgate force-pushed the clean-up branch from 3e56d28 to 1bdb400 Compare September 27, 2025 03:16

Copilot AI review requested due to automatic review settings September 27, 2025 03:42

Copilot AI reviewed Sep 27, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings September 27, 2025 12:49

strawgate force-pushed the clean-up branch from a4f5ab2 to cc2f0e6 Compare September 27, 2025 12:49

Copilot AI reviewed Sep 27, 2025

View reviewed changes

strawgate force-pushed the clean-up branch 2 times, most recently from 56b41cf to c2dcb51 Compare September 27, 2025 13:17

Copilot AI review requested due to automatic review settings September 27, 2025 13:17

Copilot AI reviewed Sep 27, 2025

View reviewed changes

key-value/key-value-shared/src/key_value/shared/utils/managed_entry.py Show resolved Hide resolved

key-value/key-value-aio/src/key_value/aio/stores/elasticsearch/store.py Outdated Show resolved Hide resolved

switch to docker lib for test fixtures

71c4731

strawgate force-pushed the clean-up branch from c2dcb51 to 71c4731 Compare September 27, 2025 13:32

Copilot AI review requested due to automatic review settings September 28, 2025 14:27

Copilot AI reviewed Sep 28, 2025

View reviewed changes

scripts/build_sync_library.py Show resolved Hide resolved

scripts/build_sync_library.py Show resolved Hide resolved

pyproject.toml Show resolved Hide resolved

Checkpoint progress

6c4b9ef

strawgate force-pushed the clean-up branch from b7fb18c to 6c4b9ef Compare September 28, 2025 14:31

Checkpoint progress

9450307

Copilot AI review requested due to automatic review settings September 28, 2025 22:26

Copilot AI reviewed Sep 28, 2025

View reviewed changes

strawgate added 2 commits September 28, 2025 17:30

Fix redis test

c36fe22

Add collection support to elasticsearch

5a18824

Copilot AI review requested due to automatic review settings September 28, 2025 22:48

Copilot AI reviewed Sep 28, 2025

View reviewed changes

Fix Elasticsearch tests

87c67d9

Copilot AI review requested due to automatic review settings September 29, 2025 01:34

Copilot AI reviewed Sep 29, 2025

View reviewed changes

Cleanup from code review

086898e

strawgate force-pushed the clean-up branch from 2be41d4 to 086898e Compare September 29, 2025 01:39

strawgate changed the title ~~General Clean-up~~ Stabilize the Protocol and implement add't Stores Sep 29, 2025

strawgate merged commit b0f5adf into main Sep 29, 2025
24 checks passed

Stabilize the Protocol and implement add't Stores #16

Stabilize the Protocol and implement add't Stores #16

Uh oh!

Conversation

strawgate commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

strawgate commented Sep 25, 2025 •

edited

Loading