Eth 138 migrate streams to ocr #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing validity of ids
…ported by thegraph, need to remove the method from abi)
jtakalai
approved these changes
Dec 14, 2021
| // first register ens domain on mainnet | ||
| // scripts/deploy.js | ||
|
|
||
| import * as fs from 'fs' |
There was a problem hiding this comment.
maybe use fs/promises instead
| let resolver: any | ||
| const promise = new Promise((resolve) => { resolver = resolve }) | ||
|
|
||
| fs.readFile(PROGRESS_FILENAME, 'utf8', (err, data) => { |
There was a problem hiding this comment.
...and use const data = await fs.readFile in here
There was a problem hiding this comment.
(readFileSync is fine too)
| await mtx.wait(2) | ||
| console.log('added migrator role to ' + migratorWallet.address) | ||
| let resolver: any | ||
| const promise = new Promise((resolve) => { resolver = resolve }) |
There was a problem hiding this comment.
maybe also take the (resolve, reject)...
| }) | ||
| .on('error', (err: any) => { | ||
| console.log('Error while reading file.', err) | ||
| }) |
There was a problem hiding this comment.
...and reject the promise here
…eams_to_ocr * origin/master: replaced DaisyDomergue as the assignee in the dependabot config (#99) ci: bump actions/stale from 4.0.0 to 4.1.0 (#101) ci: bump actions/setup-node from 2.4.1 to 2.5.0 (#95) renamed subgraph; added deploy-local and deploy from within docker tasks; fix e2eTest script renaming of permission attributes (#100) build(deps): bump solidity-coverage in /packages/smartcontracts (#89) build(deps): bump hardhat-dependency-compiler (#87) build(deps): bump @types/chai in /packages/smartcontracts (#52) build(deps-dev): bump eslint-plugin-standard (#41) build(deps): bump @ethersproject/wallet in /packages/smartcontracts (#69) build(deps-dev): bump @types/debug in /packages/smartcontracts (#37) build(deps-dev): bump eslint-config-streamr-nodejs (#83) build(deps-dev): bump eslint-config-streamr-nodejs (#82) # Conflicts: # packages/smartcontracts/contracts/StreamRegistry/StreamRegistry.sol # packages/smartcontracts/package-lock.json # packages/smartcontracts/package.json
kare
pushed a commit
that referenced
this pull request
Dec 16, 2021
* added bulk add stream function and test to migrate streams from core-api * added first draft of script, parsing tsv file with all streams, checking validity of ids * further into migration script, nonce is issue * migrate script is working with manual nonces * adding an array of permissions per stream into registry ([][] not supported by thegraph, need to remove the method from abi) * migrate script does not spam mempool and saves progress to disk * added stream data clean script * refactores migration script to use new cleanded up data * little linting * detect stuck transactions, resend them with higher gasPrice working * renaming of permission attributes cherrypicked from master * reset progress file * fixed possible timing async issue
samt1803
added a commit
that referenced
this pull request
Feb 1, 2022
* master-3: [ETH-213] proxyfied registries contracts in dev env (#123) Proxify all hardhat upgrades (#118) added functionality to create Stream with ENS by triggering a chainli… (#109) checking that path characters are only a-z, A-Z, 0-9, -_/. (#111) Eth 138 migrate streams to ocr (#102) # Conflicts: # packages/docker-dev-chain-init/package-lock.json # packages/smartcontracts/.vscode/launch.json # packages/smartcontracts/contracts/StreamRegistry/StreamRegistry.sol # packages/smartcontracts/package.json # packages/smartcontracts/test/StreamRegistry.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.