-
Notifications
You must be signed in to change notification settings - Fork 5
Proxify all hardhat upgrades #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nk sync of ENS owner first, then chainlink creates the stream
moved to chainlink 0.8 from 0.6; used yarn to install dependencies since chainlink requires it;
* ETH-197_automatic_ENS_sync: added functionality to create Stream with ENS by triggering a chainlink sync of ENS owner first, then chainlink creates the stream
…are not upgradable
…grades * ETH-197_automatic_ENS_sync: now cache ich checked before triggering the chainlink sync # Conflicts: # packages/smartcontracts/scripts/e2eTest.ts
…-upgrades * origin/master: checking that path characters are only a-z, A-Z, 0-9, -_/. (#111)
…-upgrades * origin/master: added functionality to create Stream with ENS by triggering a chainli… (#109) # Conflicts: # packages/smartcontracts/contracts/StreamRegistry/StreamRegistry.sol # packages/smartcontracts/contracts/chainlinkClient/ENSCache.sol # packages/smartcontracts/deploy/deploy.js # packages/smartcontracts/scripts/e2eTest.ts # packages/smartcontracts/test/ENScache.test.ts
…me and using that ensname for the first time and thus triggering a chainlink sync, the permission on that stream was created for the enscache contract instead of the initiator of the streamcreation
yarn not needed anymore, hooray
this breaks the circular dependency (that prevents flattening)
jtakalai
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
there was a nonce issue in requestENSOwner test. We don't tx.wait() much in test code, and generally that's been ok.
…ed as tracker-registry
5d42c44
to
f6a4f57
Compare
…wing tests to fail because of async parallellism # Conflicts: # packages/smartcontracts/test/NodeRegistry.test.ts
2457401
to
1addf5b
Compare
samt1803
added a commit
that referenced
this pull request
Feb 1, 2022
* master-3: [ETH-213] proxyfied registries contracts in dev env (#123) Proxify all hardhat upgrades (#118) added functionality to create Stream with ENS by triggering a chainli… (#109) checking that path characters are only a-z, A-Z, 0-9, -_/. (#111) Eth 138 migrate streams to ocr (#102) # Conflicts: # packages/docker-dev-chain-init/package-lock.json # packages/smartcontracts/.vscode/launch.json # packages/smartcontracts/contracts/StreamRegistry/StreamRegistry.sol # packages/smartcontracts/package.json # packages/smartcontracts/test/StreamRegistry.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made contracts UUPSupgradeable, added deployscripts, added some config for prod chainlink adapter