test(network-subgraphs): [ETH-893] Move network subgraph smoke test #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Move the network subgraph smoke test from the network-contracts package into its own network-subgraphs package with dedicated TypeScript config, test script, and CI updates.
- Add a new
tsconfig.jsonscoped to the smoke tests innetwork-subgraphs - Introduce a
smoke-testscript and required devDependencies undernetwork-subgraphs - Remove legacy smoke-test config and dependencies from
network-contracts - Update CI job to invoke the new smoke test in
network-subgraphs
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/network-subgraphs/tsconfig.json | New TS config targeting the tests folder |
| packages/network-subgraphs/package.json | Added smoke-test script, ts-mocha, and @streamr/config dep |
| packages/network-contracts/package.json | Removed old smoke-test integration scripts and ts-mocha devDep |
| packages/network-contracts/.vscode/launch.json | Removed stale Mocha launch configuration |
| .github/workflows/ci.yaml | Updated CI step to run smoke-test in network-subgraphs |
harbu
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new location is better than the previous location (the
network-contractssubpackage) as it tests the subgraphs, not contracts.