This repository was archived by the owner on Dec 21, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Fix resend gapfills, improve pipeline error handling #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NET-181 Client doesn't try to recover from a gap during resend
This range happens to include an (unfillable) gap, which leads to the following behavior:
|
cfec0af to
405b6a2
Compare
teogeb
reviewed
Feb 18, 2021
teogeb
reviewed
Feb 18, 2021
teogeb
reviewed
Feb 18, 2021
…osing of pipeline.
…fer sync iterable immediately.
Only ~Close OrderMessages stream once messages sent & all gaps filled or failed.
…e gaps in ordering util.
…ure OrderMessages.
6e83a42 to
f3f986a
Compare
teogeb
approved these changes
Feb 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streamr-client-protocol8.0.0 beta-x.Also:
{ value: "11 of 20" }