Skip to content
This repository was archived by the owner on Dec 21, 2021. It is now read-only.

DataUnion Linting #203

Merged
merged 2 commits into from
Feb 23, 2021
Merged

DataUnion Linting #203

merged 2 commits into from
Feb 23, 2021

Conversation

@timoxley
Copy link
Contributor

@timoxley timoxley commented Feb 23, 2021 •
edited
Loading

A few changes on top of #202:

  • Added npm run test-types to check types in src & test.
  • Cleaned up max-len issues
  • Replaced string types with EthereumAddress as per JSDoc types
  • Removed JSDoc types in favour of ts types, kept description text.
  • Addressed various other ts warnings.

@timoxley timoxley changed the title Dataunion linting DataUnion Linting Feb 23, 2021
@timoxley timoxley merged commit 7e3e6d0 into 5.x Feb 23, 2021
@timoxley timoxley deleted the dataunion-linting branch February 23, 2021 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timoxley