This repository was archived by the owner on Dec 21, 2021. It is now read-only.
Types for authFetch #207
Merged
Types for authFetch #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jtakalai
approved these changes
Mar 2, 2021
Contributor
jtakalai
left a comment
jtakalai
left a comment
There was a problem hiding this comment.
Haha TS "laid-back" typing is really a breath of fresh air: sure, let the caller decide what the return type is; if they get it wrong, they get to suffer, whatever :D
|
|
||
| // Send data to the stream | ||
| return authFetch( | ||
| await authFetch( |
Contributor
Author
There was a problem hiding this comment.
Because the success response POST /streams/id/data is always empty. So it is better to return void than an empty object. Error response rejects the promise.
teogeb
added a commit
that referenced
this pull request
Mar 2, 2021
Types for getAdminAddress, setAdminFee, executeWithdraw. After these modifications, and PR #207 all public methods of DataUnion are annotated with valid types. Remove deployTxReceipt field which was not used
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type annotations for authFetch endpoints (and
utils.test.ts).