Skip to content
This repository was archived by the owner on Dec 21, 2021. It is now read-only.

Conversation

@teogeb
Copy link
Contributor

@teogeb teogeb commented Mar 2, 2021

Better error handling of authFetch errors: added classes ValidationError and NotFoundError.

Also smaller changes:

  • added missing id field to StreamPermission
  • strict type check of parameter in getOrCreateStream()

@teogeb teogeb requested a review from timoxley March 2, 2021 18:29
Copy link
Contributor

@timoxley timoxley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teogeb teogeb merged commit 9ccd610 into 5.x Mar 3, 2021
@teogeb teogeb deleted the stream-reject-on-error-refactor branch March 3, 2021 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants