This repository was archived by the owner on Dec 21, 2021. It is now read-only.
types(dataunion): Transfer amount to specific member #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Added transferToMemberInContract to dataunion Signed-off-by: AliReza Seyfpour <a.seyfpour@gmail.com>
aseyfpour
changed the title
Contributor
|
@aseyfpour great work, thanks for this, I'm pinging the right people to review. |
jtakalai
suggested changes
Apr 8, 2021
Contributor
jtakalai
left a comment
jtakalai
left a comment
There was a problem hiding this comment.
Code looks good, but it needs a test. Would you like to try writing one? I can also help over a video call, or do it myself later.
Contributor
|
looks fine. I prefer a test too. |
Added an integration test for transfer to member Signed-off-by: AliReza Seyfpour <a.seyfpour@gmail.com>
Contributor
Author
|
Thanks for your feedback and sorry for the delay and lots of commits. I added an integration test but I didn't know how to run it. I tried with different providers but it wasn't successful. Also, I didn't find any documentation or tutorial about how to run the tests, so I used git CI to handle this. Sorry about that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types(dataunion): Transfer amount to a specific member
Added transferToMemberInContract to dataunion
Signed-off-by: AliReza Seyfpour a.seyfpour@gmail.com