Add additional printer columns to KafkaAccess #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MichaelMorris <michael.morris@est.tech>
scholzj
reviewed
Oct 15, 2024
Member
scholzj
left a comment
scholzj
left a comment
There was a problem hiding this comment.
One nit, LGTM otherwise, thanks.
api/src/main/java/io/strimzi/kafka/access/model/KafkaReference.java
Outdated
Show resolved
Hide resolved
Signed-off-by: MichaelMorris <michael.morris@est.tech>
katheris
approved these changes
Oct 16, 2024
Member
katheris
left a comment
katheris
left a comment
There was a problem hiding this comment.
Thanks @MichaelMorrisEst, LGTM
scholzj
pushed a commit
that referenced
this pull request
Feb 2, 2025
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following additional printer columns to KafkaAccess:
For example:
Partially addresses #53