fix: sanitizes extra dollar signs for operators #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
reviewed
Jul 7, 2020
lib/mongodb.js
Outdated
| while (spec.charAt(0) === '$') { | ||
| spec = spec.substr(1); | ||
| } | ||
| return spec; |
Contributor
There was a problem hiding this comment.
The function can be simplified as follows:
function trimLeadingDollarSigns(spec) {
return spec.replace(/^(\$)+/, '');
}
jannyHou
reviewed
Jul 10, 2020
Contributor
jannyHou
left a comment
jannyHou
left a comment
There was a problem hiding this comment.
👍 LGTM in general, just a few suggestions.
| '$pop', | ||
| '$pullAll', | ||
| '$pull', | ||
| '$pushAll', |
Contributor
There was a problem hiding this comment.
any reason deleting this?
Contributor
Author
There was a problem hiding this comment.
pushAll is deprecated and being removed from MongoDB 3.6: https://docs.mongodb.com/manual/release-notes/3.6-compatibility/index.html#remove-pushall-update-operator
agnes512
force-pushed
the
fix/filter
branch
2 times, most recently
from
f696d89 to
a978ae8
Compare
jannyHou
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #532
Add a helper function that removes all extra dollar signs.
e.g
$eq->eq,$$eq->eq( don't consider the case as an error).Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine