Skip to content

fix(release): handle missing dnf in aarch64 manylinux container#53

Merged
polaz merged 1 commit intomainfrom
fix/#52-aarch64-protoc-install
May 2, 2026
Merged

fix(release): handle missing dnf in aarch64 manylinux container#53
polaz merged 1 commit intomainfrom
fix/#52-aarch64-protoc-install

Conversation

@polaz
Copy link
Copy Markdown
Member

@polaz polaz commented May 2, 2026

Summary

  • Build embedded / aarch64 (ubuntu-latest) fails in Release v1.0.1 with dnf: command not found → docker exits 127
  • aarch64 manylinux_2_28 container doesn't expose dnf in PATH; before-script falls through with exit code 127
  • Fix: fall through dnfyumapt-get so protoc installs regardless of package manager

Closes #52

The aarch64 manylinux_2_28 container does not expose dnf in PATH,
causing before-script to exit 127. Fall through dnf→yum→apt-get so
protoc installs regardless of which package manager is available.

Closes #52
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 49445654-fd06-4cd5-8e77-fab81c2cf3c1

📥 Commits

Reviewing files that changed from the base of the PR and between a7cca8e and 957d0f5.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Enhanced Linux environment compatibility in the build pipeline by improving package manager detection and installation logic.

Walkthrough

The PR modifies the embedded wheel build step's Linux setup script to conditionally install protobuf-compiler using whichever package manager is available (dnf, yum, or apt-get), fixing a build failure in the aarch64 manylinux container that lacks dnf.

Changes

CI Build Script Fix

Layer / File(s) Summary
Workflow Configuration
.github/workflows/release.yml
The before-script-linux now checks for and uses dnf, yum, or apt-get to install protobuf-compiler, replacing the single-path dnf install that failed in aarch64 containers lacking dnf.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing the release workflow to handle missing dnf in aarch64 manylinux container.
Description check ✅ Passed The description clearly relates to the changeset, explaining the problem, the fix, and the linked issue.
Linked Issues check ✅ Passed The code changes directly address issue #52's requirements by modifying the before-script to use conditional package manager checks (dnf → yum → apt-get) for protoc installation.
Out of Scope Changes check ✅ Passed All changes are scoped to the release workflow's before-script, directly addressing the protoc installation issue in the aarch64 manylinux container.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#52-aarch64-protoc-install

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 2, 2026

@polaz polaz merged commit ffddfef into main May 2, 2026
8 checks passed
@polaz polaz deleted the fix/#52-aarch64-protoc-install branch May 2, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(release): handle missing dnf in aarch64 manylinux container

1 participant