Skip to content

Conversation

@sttk
Copy link
Owner

@sttk sttk commented Jul 13, 2025

This PR is a complete rewrite of the source code.

  1. Renamed interface and class names:

    DaxDataAcc
    DaxBaseDataHub
    DaxConnDataConn
    DaxSrcDataSrc

  2. Replace sabi.Err to errs.Err

All comments have been removed. A separate PR will be created to add comments.

@sttk sttk requested a review from Copilot July 13, 2025 04:05

This comment was marked as outdated.

@sttk sttk requested a review from Copilot July 13, 2025 05:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR completes a full revision of the codebase to reflect updated naming conventions and structure, primarily renaming core interfaces and classes and updating tests accordingly.

  • Renamed interfaces and classes (DaxDataAcc, DaxBaseDataHub, DaxConnDataConn, DaxSrcDataSrc) and adjusted all imports.
  • Updated error package references from sabi.Err to errs.Err.
  • Removed all comments; a separate PR will add new documentation.

Reviewed Changes

Copilot reviewed 47 out of 48 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/test/java/com/github/sttk/sabi/internal/DataSrcListTest.java Updated imports and class names to DataSrc/DataConn; test logic kept intact.
src/test/java/com/github/sttk/sabi/internal/DataHubInnerTest.java Updated imports and class names; test cases now use DataHub and DataHubInner.
src/test/java/com/github/sttk/sabi/internal/DataConnListTest.java Updated imports and class names to DataConn and DataConnContainer.
src/test/java/com/github/sttk/sabi/internal/DataAccTest.java Updated imports and class names to DataAcc, DataHub, and Logic interfaces.
src/test/java/com/github/sttk/sabi/internal/AsyncGroupImplTest.java Updated imports and class names to AsyncGroupImpl and Runner.
Comments suppressed due to low confidence (3)

src/test/java/com/github/sttk/sabi/internal/DataSrcListTest.java:37

  • The word "setupped" is misspelled. Consider using "setup", "set up", or a clearer phrase like "setup completed".
      logger.add(String.format("SyncDataSrc %d setupped", this.id));

src/test/java/com/github/sttk/sabi/internal/DataHubInnerTest.java:1

  • [nitpick] This test class exceeds 2,000 lines, which makes it hard to navigate and maintain. Consider splitting it into smaller, focused test classes (e.g., global setup, local setup, transaction behavior).
package com.github.sttk.sabi.internal;

@sttk sttk merged commit 7f0993f into main Jul 13, 2025
9 checks passed
@sttk sttk deleted the renew branch July 13, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants