Skip to content

Conversation

@sttk
Copy link
Owner

@sttk sttk commented Jul 13, 2025

T/O.

@sttk sttk requested a review from Copilot July 13, 2025 15:21

This comment was marked as outdated.

@sttk sttk requested a review from Copilot July 13, 2025 15:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds comprehensive Javadoc to the Sabi framework’s public API and corrects a typo in an exception record.

  • Introduces Javadoc for classes, interfaces, records, and methods across multiple packages.
  • Renames the exception record from RuntimeExceptionOccured to RuntimeExceptionOccurred and updates its usages.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main/java/com/github/sttk/sabi/internal/DataHubInner.java Fix spelling of RuntimeExceptionOccurred in exception mapping
src/main/java/com/github/sttk/sabi/Sabi.java Add Javadoc for Sabi class and its static methods
src/main/java/com/github/sttk/sabi/Logic.java Add Javadoc for Logic interface and its run method
src/main/java/com/github/sttk/sabi/DataSrc.java Add Javadoc for DataSrc interface methods
src/main/java/com/github/sttk/sabi/DataHub.java Add Javadoc for DataHub, its error-records, methods, and fix typo
src/main/java/com/github/sttk/sabi/DataConn.java Add Javadoc for DataConn interface methods
src/main/java/com/github/sttk/sabi/DataAcc.java Add Javadoc for DataAcc interface and its getDataConn method
src/main/java/com/github/sttk/sabi/AsyncGroup.java Add Javadoc for AsyncGroup interface, its records, and add

@sttk sttk merged commit 7564256 into main Jul 13, 2025
12 checks passed
@sttk sttk deleted the add_javadoc branch July 13, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants