Skip to content

Issue in re-routing to non-normalized class aamp_stimp #576

@NimaSarajpoor

Description

@NimaSarajpoor

I was trying to do some experiment with pan matrix profile and I noticed there is a problem in re-routing from class stimp to aamp_stimp when normalize=False.

Error:

Excluding `['normalize', 'p']` parameters, 
`<class 'stumpy.stimp.stimp'>`: (['T', 'min_m', 'max_m', 'step', 'percentage', 'pre_scrump']) and 
`<class 'stumpy.aamp_stimp.aamp_stimp'>`: (['T', 'min_m', 'max_m', 'step', 'percentage', 'pre_scraamp']) 
have different parameters.

Solution:
Modifying the decorator as follows:

# in stimp.py
@core.non_normalized(aamp_stimp,
                    exclude=["pre_scrump", "normalize", "pre_scraamp"],
                    replace={"pre_scrump": "pre_scraamp"}
                    )
class stimp(_stimp):
    ....

(I checked it on my end and I think it works)

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions