-
Notifications
You must be signed in to change notification settings - Fork 338
Closed
Labels
bugSomething isn't workingSomething isn't working
Milestone
Description
There appears to be a bug in the ostinato (and variants) algorithm where the list of time series being passed into the function are also (possibly, in some rare cases) being incorrectly overwritten after they have been core.preprocessed:
This isn't a problem when there are no np.nan/np.inf in the data since the time series that gets passed back will be identical to the input time series. However, in the rare case, when there are np.nan/np.inf in the time series, those parts of the time series get preprocessed into 0.0 and then this converted time series overwrites the original element within the input list of time series Ts.
What we should do is:
- make a copy of the input list,
Ts, and also each time series,Ts[i], so that the originalTs/Ts[i]is NOT overwritten - Add a unit test to check that the input is not overwritten in
Ts(especially when there arenp.nan/np.infin the data
Something like:
Ts_copy = []
for T in Ts:
Ts_copy.append(T.copy())
and then use Ts_copy everywhere and overwrite where necessary
NimaSarajpoor
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working