Support for Functional Components #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JocD
commented
Mar 20, 2017
JocD
commented
- Added support for functional components
- Updated dependencies
# Conflicts: # examples/react-styleguidist-example/styleguide.config.js
Added tests to validate prop.isRequired
|
I try to write as many of my components as functional components, so I extended your parser to be able to handle them. A few things to note:
|
|
That's excellent. Stateless components, typescript version updated, typings replaced with @types. Thanks a lot for your huge PR. |
pvasek
added a commit
that referenced
this pull request
Sep 8, 2017
Add failing test for extending props from an external .tsx file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.