You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Node.js removed the buffer.toArrayBuffer() API sometime during node 0.11. Users who rely on it will have code that doesn't work in node.js, which is unfortunate.
feross/buffer v4.0.0 removed buffer.toArrayBuffer() to have parity with node.js.
Going forward, users can just use buffer.buffer to get an ArrayBuffer since Buffer is just a subclass of Uint8Array in both node.js and the browser.
This is a breaking change, since we're removing a method from the buffer.
I'm only sending this PR now, since buffer v4.1.0 has a 30% performance increase for lots of the buffer methods and I want users to have that 👍
This release bumps the buffer dependency to v4, which has one possible breaking change:
The buffer.toArrayBuffer() method on Buffer instances has been removed.
(This is probably not a problem for 99.9% of users.)
This API was added in node v0.11.8 and removed before v0.12 was released.
It was added to browserify's buffer implementation but was never removed when v0.12
was released. buffer v4 removes it so we have full parity with node.js.
Going forward, to get an ArrayBuffer from a node.js-style Buffer, users should
just use buffer.buffer. This works because Buffer is a subclass of Uint8Array
in both the browser and node.js (since v3).
On the plus side, this release also includes:
Performance improvements to buffer that increase the speed of some buffer
methods by as much as 30%!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js removed the
buffer.toArrayBuffer()API sometime during node 0.11. Users who rely on it will have code that doesn't work in node.js, which is unfortunate.feross/bufferv4.0.0 removedbuffer.toArrayBuffer()to have parity with node.js.Going forward, users can just use
buffer.bufferto get anArrayBuffersinceBufferis just a subclass ofUint8Arrayin both node.js and the browser.This is a breaking change, since we're removing a method from the buffer.
I'm only sending this PR now, since buffer v4.1.0 has a 30% performance increase for lots of the buffer methods and I want users to have that 👍