Update glob dependency #1602
Closed
Update glob dependency #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would you please update glob and push to master? I have this issue with cordova I asked Cordova team on Jira about it, I opened a bug report, it was labeled as critical and they said that bug is because of you guys, browserify hasn't updated to glob-7 This fix is so old an not merged yet, so many projects depend on this library so please merge. If you don't merge soon, I'm going to fork, update dependency and convince Cordova team to use my fork. |
Author
|
Closing due to lack of interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently installing
browserifygives a warning:This PR updates the
globdependency to the most recent version which uses an updatedminimatchversion as well.I ran the tests after the change and they all still pass.