Skip to content

list bundled browser-launcher as a dependency#36

Merged
ljharb merged 1 commit intotape-testing:masterfrom
hurrymaplelad:extraneous
Sep 19, 2022
Merged

list bundled browser-launcher as a dependency#36
ljharb merged 1 commit intotape-testing:masterfrom
hurrymaplelad:extraneous

Conversation

@hurrymaplelad
Copy link
Contributor

npm install && npm ls yields

npm ERR! extraneous: browser-launcher@0.2.0 testling/node_modules/browser-launcher

@isaacs suggests that bundled dependencies still need to be regular dependencies.

@ljharb
Copy link
Collaborator

ljharb commented Jan 10, 2020

@hurrymaplelad would you mind checking "allow edits" on the RHS of this PR?

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was done in 6a4ee9a; i'll rebase this to update it.

@ljharb ljharb merged commit 33436d5 into tape-testing:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants