fix(core): start with functionAnchor one instead of zero#408
Merged
vbarua merged 1 commit intosubstrait-io:mainfrom Jun 6, 2025
Merged
fix(core): start with functionAnchor one instead of zero#408vbarua merged 1 commit intosubstrait-io:mainfrom
vbarua merged 1 commit intosubstrait-io:mainfrom
Conversation
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-consumer-testing
that referenced
this pull request
Jun 10, 2025
This commit updates the `substrait-java` submodule to the next version, which breaks the tests, namele substrait-io/substrait-java@007accf. The breakages are due to substrait-io/substrait-java#408, which changes the index at which anchors start, which basically changes every plan that Isthmus prodces. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/substrait-consumer-testing
that referenced
this pull request
Jun 10, 2025
This commit updates the `substrait-java` submodule to the next version, which breaks the tests, namely substrait-io/substrait-java@007accf. The breakages are due to substrait-io/substrait-java#408, which changes the index at which anchors start, which basically changes every plan that Isthmus produces. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to substrait-io/consumer-testing
that referenced
this pull request
Jun 10, 2025
This PR updates the `substrait-java` submodule to the next version, which breaks the tests, namely substrait-io/substrait-java@007accf. The breakages are due to substrait-io/substrait-java#408, which changes the index at which anchors start, which basically changes every plan that Isthmus produces. This PR also updates all snapshots. The only changes seem to be updates of anchors and references to them. Signed-off-by: Ingo Müller <ingomueller@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When validating Substrait plans generated by substrait-java with the current substrait-validator (which is pretty out of date) the validator gives the following warning for all plans:
This can be easily fixed by assigning functionAnchor values starting from one instead of zero.