fix: add fall-back version in case everything else fails#413
Merged
vbarua merged 1 commit intosubstrait-io:mainfrom Jun 12, 2025
Merged
fix: add fall-back version in case everything else fails#413vbarua merged 1 commit intosubstrait-io:mainfrom
vbarua merged 1 commit intosubstrait-io:mainfrom
Conversation
Signed-off-by: Ingo Müller <ingomueller@google.com>
vbarua
approved these changes
Jun 12, 2025
Member
vbarua
left a comment
vbarua
left a comment
There was a problem hiding this comment.
I think this is reasonable while we iron out the kinks in the version lookup. It's also easy-ish to notice as a user in the plans you produce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose to add a final fall back to version
0.0.0in case all other look-ups fail. Arguably it is better to tag plans with that version than crashing on every possible utilisation.