Skip to content

Conversation

@nielspardon
Copy link
Member

@nielspardon nielspardon commented Oct 20, 2025

this PR fixes and updates the VS Code devcontainer:

  • fix: the previous image mcr.microsoft.com/vscode/devcontainers/python:3.9-buster was dropped
    by Microsoft so switching to a version without specifying the Debian base version and upgrading
    to Python 3.13
  • updates Graal to 25
  • updates ANTLR to 4.13.2
  • updates protoc to 30.2
  • updates buf to 1.58.0
  • updates uv to the latest version
  • adds the --format=docker build option which makes the SHELL dockerfile instruction work with
    podman
  • adds a postCreateCommand that creates a virtualenv and install the dependencies into it
  • adds some VS Code settings for pytest integration

Signed-off-by: Niels Pardon <par@zurich.ibm.com>
@CLAassistant
Copy link

CLAassistant commented Oct 20, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

ACTION NEEDED

Substrait follows the Conventional Commits
specification
for
release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

Copy link
Contributor

@tokoko tokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrew-coleman andrew-coleman merged commit a631919 into substrait-io:main Oct 21, 2025
18 of 19 checks passed
@tokoko
Copy link
Contributor

tokoko commented Oct 25, 2025

@nielspardon looks like I didn't actually rebuild my devcontainer while taking a look at this. --format=docker will unfortunately fail for people using docker rather than podman. I opened #116 removing SHELL instruction entirely instead.

@nielspardon nielspardon deleted the par-devcontainer branch October 29, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants