Skip to content

Conversation

@nielspardon
Copy link
Member

@nielspardon nielspardon commented Oct 21, 2025

This PR fixes the import issue by upgrading the protobuf dependency and related dependencies
to a consistent version.

  • update protobuf to v5.29.5
  • downgrade protoc in devcontainer to v29.5
  • update nipunn1313-mypy buf plugin to v3.6.0
  • regenerate proto Python code with protobuf v5.29.5
  • update uv.lock

fixes #110

@github-actions
Copy link

ACTION NEEDED

Substrait follows the Conventional Commits
specification
for
release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@mbwhite
Copy link
Contributor

mbwhite commented Oct 21, 2025

In previous projects with protobufs the approach taken has been to avoid checking in the generated code; and have it created from a known level of the protobuf definitions; that way the generated code is always at the correct level and not something that might have created from any other level. Especially when the same proto definitions are used across projects with differing languages.

Just an observations based on past experience.

@nielspardon nielspardon force-pushed the par-protobuf branch 2 times, most recently from 54bf9e3 to ac6a3bf Compare October 21, 2025 13:17
- update protobuf to v5.29.5
- downgrade protoc in devcontainer to v29.5
- update nipunn1313-mypy buf plugin to v3.6.0
- regenerate proto Python code with protobuf v5.29.5
- update uv.lock

Signed-off-by: Niels Pardon <par@zurich.ibm.com>
@EpsilonPrime
Copy link
Member

In previous projects with protobufs the approach taken has been to avoid checking in the generated code; and have it created from a known level of the protobuf definitions; that way the generated code is always at the correct level and not something that might have created from any other level. Especially when the same proto definitions are used across projects with differing languages.

Just an observations based on past experience.

Here we are checking it in to avoid extra dependencies (and build steps) when installing the Python package.

@nielspardon nielspardon merged commit 711bd96 into substrait-io:main Oct 22, 2025
18 checks passed
@nielspardon nielspardon deleted the par-protobuf branch October 29, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update protobuf dependency to v5.x in accordance with most recent protoletariat version

3 participants