Skip to content

Conversation

mikeller
Copy link
Member

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Code cleanup
  • Build system change
  • Documentation change
  • Language translation

Pull request long description:

Add a column for dive notes to the dive list table. The column is disabled by default.
As requested in
https://groups.google.com/g/subsurface-divelog/c/PEFre85Ek1M.

Changes made:

  1. add new column for dive notes to the dive list table;
  2. mak it sort alphabetically;
  3. pivot the list of initially shown columns to be based on a list of showing columns instead of hidden ones, to make addition of new columns more intuitive.

Related issues:

https://groups.google.com/g/subsurface-divelog/c/PEFre85Ek1M

Additional information:

Screenshot from 2023-03-16 13-17-04

Release note:

desktop: add column for dive notes to the dive list table

Documentation change:

Mentions:

Signed-off-by: Michael Keller github@ike.ch

Add a column for dive notes to the dive list table.
The column is disabled by default.
As requested in
https://groups.google.com/g/subsurface-divelog/c/PEFre85Ek1M.

Signed-off-by: Michael Keller <github@ike.ch>
Copy link
Collaborator

@atdotde atdotde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me likes. I would have expected that the room is not sufficient to show useful information but indeed that is not the case.

@atdotde atdotde merged commit 5b263a8 into subsurface:master Mar 16, 2023
@mikeller mikeller deleted the add_notes_to_divelist branch March 16, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants