BUNDLED_AVR_TOOLS_DIR is now set correctly #161
Conversation
so that installations using only the arduino-core packages that don't have the $(ARDUINO_DIR)/hardware/tools/avr directory can still use the avr-g++ tools found in the $PATH (/usr/bin) Previously BUNDLED_AVR_TOOLS_DIR was set to an empty string as the directory doesn't exist, which meant that "ifdef BUNDLED_AVR_TOOLS_DIR..." was set rather than skipping to "else SYSTEMPATH_AVR_TOOLS_DIR...." No user would set BUNDLED_AVR_TOOLS_DIR so the assignment operator := should be used not ?= Updated the version info/changes in various locations.
BUNDLED_AVR_TOOLS_DIR is now set correctly
|
Thanks. Just merged it. But don't create the package yet. Let's fix #75 also as part of |
|
sure, a one character typo is hardly worth doing a release for ;-) not sure how you want to go about the documentation - its too much for a manpage, so probably just make it into a github markup file and link to it from readme? |
I am still not completely sure how to implement it though. Following are some ways in which we can do.
|
|
i'd say just bung it in a MD file for now as a starting point, then work on doxygen or something later. maybe keep the issue open. i'm hesitant to put it in the makefiles as there will be too many comments, its ok to document functions that way but every variable will be overwhelming, same as a manpage. we could possibly do a "make help-variables" that would "more" the MD file? |
|
I agree with you. Let's do it as you suggested. |
3 participants
BUNDLED_AVR_TOOLS_DIR is now set correctly using := instead of ?=, so that installations using only the arduino-core packages that don't have the $(ARDUINO_DIR)/hardware/tools/avr directory can still use the avr-g++ tools found in the $PATH (/usr/bin) without having to install the whole arduino IDE, e.g. raspberry pi.
Previously BUNDLED_AVR_TOOLS_DIR was set to an empty string (that's what ?= does for unset variables) as the directory doesn't exist, which meant that "ifdef BUNDLED_AVR_TOOLS_DIR..." was set to empty, rather than skipping to "else SYSTEMPATH_AVR_TOOLS_DIR...."
No user would set BUNDLED_AVR_TOOLS_DIR so the assignment operator := should be used not ?=
Updated the version info/changes in various locations.