Quote/regex/wildcard audit (fixes issue #192) #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with spaces in directory/file-names. Removed $TARGETS as it was an unsafe wildcard and was only used in "make clean" which itself has been simplified to just delete the $OBJDIR rather than waste time deleting individual files.
sudar
added a commit
that referenced
this pull request
Jun 29, 2014
Quote/regex/wildcard audit (fixes issue #192)
Owner
|
Thanks. Just merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #192
Added quotes around greps/cats to help alleviate possible problems with spaces in directory/file-names. Still the possibility for problems with
includelines as they don't respect quotes, so would need escaping.Removed
$TARGETSas it was an unsafe wildcard and was only used inmake cleanwhich itself has been simplified to just delete the$OBJDIRrather than waste time deleting individual files.