Skip to content

Conversation

@sej7278
Copy link
Collaborator

@sej7278 sej7278 commented Jun 30, 2014

Fixes issue #82

Tidies up the build-* directory with a 4-line fix. Tested with alternate cores and multiple libraries (and even my 1.5 branch):

core/
libcore.a
libs/
weather24ard_txnet.d
weather24ard_txnet.eep
weather24ard_txnet.elf
weather24ard_txnet.hex
weather24ard_txnet.hex.sizeok
weather24ard_txnet.o

@sudar sudar added this to the 1.3.4 milestone Jul 1, 2014
sudar added a commit that referenced this pull request Jul 1, 2014
Build core objects in subdirectory, fix issue #82 and fix #218
@sudar sudar merged commit 1f950db into sudar:master Jul 1, 2014
@sudar
Copy link
Owner

sudar commented Jul 1, 2014

As always thank you very much @sej7278

Just merged it.

@sudar
Copy link
Owner

sudar commented Jul 2, 2014

@sej7278 BTW, do you think we can make 1.3.4 release now and then start working on 1.5 by merging your 1.5 branch?

@sej7278
Copy link
Collaborator Author

sej7278 commented Jul 2, 2014

probably time to make a 1.3.4 yes, i was thinking that yesterday

up to you regarding merging my 1.5 changes - it certainly doesn't break anything in 1.0

1.5 support isn't finished i don't think, would be nice to test on some non-avr kit, but we've got to start somewhere and it is a pretty easy merge right now - just one patch

@sudar
Copy link
Owner

sudar commented Jul 12, 2014

@sej7278 I have just made the v1.3.4 release. Kindly update the debian package.

Also, let's start to merge your 1.5 changes into master and once we are done with full testing we can make the 1.5 release.

What do you say?

@sej7278
Copy link
Collaborator Author

sej7278 commented Jul 12, 2014

sure, do you want me to do a pull request for 1.5 ?

@sudar
Copy link
Owner

sudar commented Jul 12, 2014

Yes please. —
Sent from Handheld device. Excuse typos.

http://sudarmuthu.com
http://hardwarefun.com

On Sat, Jul 12, 2014 at 10:19 PM, sej7278 notifications@github.com
wrote:

sure, do you want me to do a pull request for 1.5 ?

Reply to this email directly or view it on GitHub:
#218 (comment)

@sej7278
Copy link
Collaborator Author

sej7278 commented Jul 12, 2014

Rebased 1.5 and made pull request #222

Test Fedora/Debian builds of 1.3.4 here

I'll email ScottH in a mo

@sudar
Copy link
Owner

sudar commented Jul 13, 2014

@sej7278 Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants