✨(frontend) update labels and shared document icon accessibility #1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/880-shared-doc-icon-labels
branch
from
5ad44ae to
133535b
Compare
|
Size Change: +10 B (0%) Total Size: 3.65 MB
|
AntoLC
approved these changes
Oct 2, 2025
remove aria-labels from decorative icons and add sr-only text to shared doc icon Signed-off-by: Cyril <c.gromoff@gmail.com>
Ovgodd
force-pushed
the
fix/880-shared-doc-icon-labels
branch
from
133535b to
18f4ab8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve accessibility of doc shared icons by ensuring content is exposed to screen readers. Decorative icons should not be announced, while functional ones (like the shared document icon) must provide clear context with sr-only trick.
issue : 880
Proposal
Remove aria-label attributes from purely decorative icons so they remain invisible to screen readers
Replace the default icon names (public, vpn_lock) with meaningful SR-only labels:
Add an sr-only label to the shared document icon, ensuring screen readers announce it properly
Accessible to anyone (if isPublic)
Accessible to authenticated users (otherwise)