-
Notifications
You must be signed in to change notification settings - Fork 414
🐛(frontend) fix overlapping placeholders in multi-column layout #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e2a71b9
to
8808f81
Compare
Size Change: +56 B (0%) Total Size: 3.66 MB
|
8808f81
to
ae30751
Compare
.bn-block-content[data-is-empty-and-focused][data-content-type='paragraph'] | ||
.bn-inline-content:has(> .ProseMirror-trailingBreak:only-child)::before { | ||
position: static !important; /* override absolute positioning from lib */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working ok but there is a few side effects by doing like that, this part become somehow clickable, making the cursor at the end.
In collaboration, we have a scrollbar appearing sometimes and some cases where it will move the editors line for other collaborator:

20251007-0840-11.6025223.mp4
What about that instead, with ellipsis when reaching the end ?
.bn-block-content[data-is-empty-and-focused][data-content-type='paragraph']
.bn-inline-content:has(> .ProseMirror-trailingBreak:only-child)::before {
text-overflow: ellipsis;
white-space: nowrap;
overflow: hidden;
width: inherit;
height: inherit;
}
.bn-block-content[data-is-empty-and-focused][data-content-type='paragraph']
.bn-inline-content:has(> .ProseMirror-trailingBreak:only-child) {
position: relative;
}

Open to suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didn't see those side effects, nice catch,
hm IMO your suggestion is good and far better.
ae30751
to
e8dbd16
Compare
5ae723c
to
fe2862d
Compare
placeholders no longer overlap when adding 2–3 column, text wraps correctly Signed-off-by: Cyril <c.gromoff@gmail.com>
fe2862d
to
51c5c4e
Compare
Purpose
Fix visual issues with placeholders overlapping when multiple columns are created.
Ensure placeholder text is truncated with ellipsis, avoiding confusion when adding multiple columns.
columnslice.mp4
issue : 1445
Proposal