Skip to content

Conversation

Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Oct 6, 2025

Purpose

Fix visual issues with placeholders overlapping when multiple columns are created.
Ensure placeholder text is truncated with ellipsis, avoiding confusion when adding multiple columns.

columnslice.mp4

issue : 1445

Proposal

  • Prevent overlapping of placeholder content in multi-column layout
  • Apply proper text truncation for 2–3 column configurations
  • Improve user perception of column creation success

@Ovgodd Ovgodd requested a review from AntoLC October 6, 2025 15:04
@Ovgodd Ovgodd self-assigned this Oct 6, 2025
@Ovgodd Ovgodd added bug Something isn't working frontend editor columns labels Oct 6, 2025
@Ovgodd Ovgodd force-pushed the fix/1445-broken-columns-ux branch 2 times, most recently from e2a71b9 to 8808f81 Compare October 6, 2025 15:06
@Ovgodd Ovgodd marked this pull request as ready for review October 6, 2025 15:06
Copy link

github-actions bot commented Oct 6, 2025

Size Change: +56 B (0%)

Total Size: 3.66 MB

Filename Size Change
apps/impress/out/_next/static/91211b7c/_buildManifest.js 0 B -864 B (removed) 🏆
apps/impress/out/_next/static/56140772/_buildManifest.js 863 B +863 B (new file) 🆕

compressed-size-action

@Ovgodd Ovgodd force-pushed the fix/1445-broken-columns-ux branch from 8808f81 to ae30751 Compare October 7, 2025 06:26
@AntoLC AntoLC linked an issue Oct 7, 2025 that may be closed by this pull request
@AntoLC AntoLC removed a link to an issue Oct 7, 2025
.bn-block-content[data-is-empty-and-focused][data-content-type='paragraph']
.bn-inline-content:has(> .ProseMirror-trailingBreak:only-child)::before {
position: static !important; /* override absolute positioning from lib */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working ok but there is a few side effects by doing like that, this part become somehow clickable, making the cursor at the end.

In collaboration, we have a scrollbar appearing sometimes and some cases where it will move the editors line for other collaborator:

Image
20251007-0840-11.6025223.mp4

What about that instead, with ellipsis when reaching the end ?

.bn-block-content[data-is-empty-and-focused][data-content-type='paragraph']
      .bn-inline-content:has(> .ProseMirror-trailingBreak:only-child)::before {
      text-overflow: ellipsis;
      white-space: nowrap;
      overflow: hidden;
      width: inherit;
      height: inherit;
    }

    .bn-block-content[data-is-empty-and-focused][data-content-type='paragraph']
      .bn-inline-content:has(> .ProseMirror-trailingBreak:only-child) {
      position: relative;
    }
Image

Open to suggestion.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't see those side effects, nice catch,

hm IMO your suggestion is good and far better.

@Ovgodd Ovgodd force-pushed the fix/1445-broken-columns-ux branch from ae30751 to e8dbd16 Compare October 7, 2025 09:23
@Ovgodd Ovgodd requested a review from AntoLC October 7, 2025 09:36
@Ovgodd Ovgodd force-pushed the fix/1445-broken-columns-ux branch from 5ae723c to fe2862d Compare October 8, 2025 07:37
placeholders no longer overlap when adding 2–3 column, text wraps correctly

Signed-off-by: Cyril <c.gromoff@gmail.com>
@Ovgodd Ovgodd force-pushed the fix/1445-broken-columns-ux branch from fe2862d to 51c5c4e Compare October 8, 2025 07:38
@Ovgodd Ovgodd merged commit 51c5c4e into main Oct 8, 2025
20 of 22 checks passed
@Ovgodd Ovgodd deleted the fix/1445-broken-columns-ux branch October 8, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants