Skip to content

Conversation

Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Oct 14, 2025

Purpose

Improve accessibility by adding a missing aria-label to the "add sub-doc" button.
This allows screen readers to correctly identify the purpose of the button and improves the experience for users relying on assistive technologies.

issue : 1391

Proposal

  • Add descriptive aria-label to the "add sub-doc" button
  • Ensure compliance with accessibility best practices

@Ovgodd Ovgodd requested a review from AntoLC October 14, 2025 07:05
@Ovgodd Ovgodd self-assigned this Oct 14, 2025
@Ovgodd Ovgodd added bug Something isn't working accessibility labels Oct 14, 2025
@Ovgodd Ovgodd changed the title ✨(frontend) add missing aria-label to add sub-doc button for accessib… ♿(frontend) add missing aria-label to add sub-doc button for accessib… Oct 14, 2025
@Ovgodd Ovgodd force-pushed the fix/1391-missing-aria-label-add-btn branch from aa719dc to 4bb5232 Compare October 14, 2025 07:06
@Ovgodd Ovgodd marked this pull request as ready for review October 14, 2025 07:07
Copy link

github-actions bot commented Oct 14, 2025

Size Change: +11 B (0%)

Total Size: 3.66 MB

Filename Size Change
apps/impress/out/_next/static/1e2d4b95/_buildManifest.js 0 B -881 B (removed) 🏆
apps/impress/out/_next/static/0aa0a374/_buildManifest.js 882 B +882 B (new file) 🆕

compressed-size-action

@AntoLC AntoLC linked an issue Oct 15, 2025 that may be closed by this pull request
CHANGELOG.md Outdated
- ♿ restyle checked checkboxes: removing strikethrough #1439
- ♿ add h1 for SR on 40X pages and remove alt texts #1438
- ♿ update labels and shared document icon accessibility #1442
- ♿ add missing aria-label to add sub-doc button for accessib… #1480
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When 3.8.0 will be released, you will have to move this part under Unreleased.

@Ovgodd Ovgodd force-pushed the fix/1391-missing-aria-label-add-btn branch 2 times, most recently from 1c557b5 to 62e77dd Compare October 16, 2025 12:15
improves screen reader support for the add sub-doc action in the document tree

Signed-off-by: Cyril <c.gromoff@gmail.com>
@Ovgodd Ovgodd force-pushed the fix/1391-missing-aria-label-add-btn branch from 62e77dd to 278eb23 Compare October 16, 2025 12:19
@Ovgodd Ovgodd merged commit 278eb23 into main Oct 16, 2025
21 of 22 checks passed
@Ovgodd Ovgodd deleted the fix/1391-missing-aria-label-add-btn branch October 16, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility bug Something isn't working frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The add page button does not have an accessible name

2 participants