Skip to content

Conversation

Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Oct 14, 2025

Purpose

Improve accessibility by adding a missing aria-label to the "more options" button
for sub-documents. This ensures the button is clearly identified by screen readers.

issue : 1392

Capture d'écran 2025-10-14 092920

Proposal

  • Add descriptive aria-label to the "more options" button on sub-docs

@Ovgodd Ovgodd requested a review from AntoLC October 14, 2025 07:31
@Ovgodd Ovgodd self-assigned this Oct 14, 2025
@Ovgodd Ovgodd force-pushed the fix/1392-missing-aria-label-more-opts branch from ddd781a to 7b56878 Compare October 14, 2025 07:33
@Ovgodd Ovgodd marked this pull request as ready for review October 14, 2025 07:33
@Ovgodd Ovgodd changed the title ✨(frontend) add missing aria-label to more options button on sub-docs ♿(frontend) add missing aria-label to more options button on sub-docs Oct 14, 2025
@Ovgodd Ovgodd force-pushed the fix/1392-missing-aria-label-more-opts branch from 7b56878 to d505cb9 Compare October 14, 2025 07:34
Copy link

github-actions bot commented Oct 14, 2025

Size Change: -8 B (0%)

Total Size: 3.66 MB

Filename Size Change
apps/impress/out/_next/static/ddbd5296/_buildManifest.js 0 B -882 B (removed) 🏆
apps/impress/out/_next/static/770c1acb/_buildManifest.js 882 B +882 B (new file) 🆕

compressed-size-action

@AntoLC AntoLC linked an issue Oct 15, 2025 that may be closed by this pull request
CHANGELOG.md Outdated
- ♿ restyle checked checkboxes: removing strikethrough #1439
- ♿ add h1 for SR on 40X pages and remove alt texts #1438
- ♿ update labels and shared document icon accessibility #1442
- ♿ add missing aria-label to more options button on sub-docs #1481
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When 3.8.0 will be released, you will have to move this part under Unreleased.

@Ovgodd Ovgodd force-pushed the fix/1392-missing-aria-label-more-opts branch 3 times, most recently from 2ce87db to 3753108 Compare October 16, 2025 12:18
improves accessibility by making the options button screen reader friendly

Signed-off-by: Cyril <c.gromoff@gmail.com>
@Ovgodd Ovgodd force-pushed the fix/1392-missing-aria-label-more-opts branch from 3753108 to e2298a3 Compare October 16, 2025 13:02
@Ovgodd Ovgodd merged commit e2298a3 into main Oct 16, 2025
21 of 22 checks passed
@Ovgodd Ovgodd deleted the fix/1392-missing-aria-label-more-opts branch October 16, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The "more options" button is not keyboard accessible

2 participants