Skip to content

🐛(pdf) fix table cell alignment issue in exported documents #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

🐛(pdf) fix table cell alignment issue in exported documents #1582

merged 1 commit into from
Nov 14, 2025
+10 −1

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Nov 12, 2025 •
edited
Loading

Purpose

Improve the visual rendering of tables in PDF exports by aligning cell content according to the specified alignment (textAlign) in the editor.

issue : #1579

alignment

Proposal

  • Add textAlign and width: 100% directly to the node inside
  • Preserve fallback to left alignment if none is specified

@Ovgodd Ovgodd requested a review from AntoLC November 12, 2025 13:11
@Ovgodd Ovgodd self-assigned this Nov 12, 2025
@Ovgodd Ovgodd added bug Something isn't working triage labels Nov 12, 2025
@Ovgodd Ovgodd force-pushed the fix/1579-table-centered-text-export-pdf branch from 0ba6f4b to 324f456 Compare November 12, 2025 13:11
@Ovgodd Ovgodd marked this pull request as ready for review November 12, 2025 13:11
@github-actions
Copy link

github-actions bot commented Nov 12, 2025 •
edited
Loading

Size Change: +31 B (0%)

Total Size: 4.07 MB

Filename Size Change
apps/impress/out/_next/static/aac1aff9/_buildManifest.js 0 B -883 B (removed) 🏆
apps/impress/out/_next/static/eddd5b07/_buildManifest.js 882 B +882 B (new file) 🆕

compressed-size-action

@AntoLC AntoLC force-pushed the fix/1579-table-centered-text-export-pdf branch 2 times, most recently from 305cc66 to 85418c1 Compare November 14, 2025 11:23
AntoLC
AntoLC approved these changes Nov 14, 2025
View reviewed changes
Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !

@Ovgodd Ovgodd force-pushed the fix/1579-table-centered-text-export-pdf branch from 85418c1 to 324f456 Compare November 14, 2025 12:09
@Ovgodd
✨(pdf) fix table cell alignment issue in exported documents
dc12a99 
ensures correct horizontal alignment of text based on cell props

Signed-off-by: Cyril <c.gromoff@gmail.com>
@Ovgodd Ovgodd force-pushed the fix/1579-table-centered-text-export-pdf branch from 324f456 to dc12a99 Compare November 14, 2025 12:10
@Ovgodd Ovgodd merged commit dc12a99 into main Nov 14, 2025
21 of 22 checks passed
@Ovgodd Ovgodd deleted the fix/1579-table-centered-text-export-pdf branch November 14, 2025 12:42
@AntoLC AntoLC linked an issue Nov 17, 2025 that may be closed by this pull request
Text not centered in a table when exporting to PDF #1579
Closed
@AntoLC AntoLC mentioned this pull request Nov 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntoLC AntoLC AntoLC approved these changes

Assignees

@Ovgodd Ovgodd

Labels

bug Something isn't working triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Text not centered in a table when exporting to PDF

3 participants

@Ovgodd @AntoLC